856370 - Remove VPATH from webspeech/Makefile.in

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Eitan Isaacson [:eeejay]]

I think we decided to have separate modules for synthesis and recognition. We also talked about VPATH being generally bad.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Add a Makefile.in in webspeech/recognition and remove webspeech top-level VPATH.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 731576 [details] [diff] [review]
Add a Makefile.in in webspeech/recognition and remove webspeech top-level VPATH.

I think you should add dom_webspeech.xpt to removed-files.in, and you could 
just move Makefile.in and moz.build to the new place and modify them there.

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Move webspeech/Makefile.in to recognition folder.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 732548 [details] [diff] [review]
Move webspeech/Makefile.in to recognition folder.

Not sure you need #ifdef in removed-files.in

Comment 5

[Eitan Isaacson [:eeejay]]

(In reply to Olli Pettay [:smaug] from comment #4)
> Comment on attachment 732548 [details] [diff] [review]
> Move webspeech/Makefile.in to recognition folder.
> 
> Not sure you need #ifdef in removed-files.in

Yeah, not sure why I would. I just saw it used elsewhere. I'll remove them.

Comment 6

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/55ec568f51a2

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/55ec568f51a2

Comment 8

[Frank Wein [:mcsmurf]]

Just a comment on the removed-files.in patch: I think this was not really needed as all .xpt files get merged into interfaces.xpt (inside omni.jar) or browser.xpt (when building without omni.jar) when packaging the installer/updater. So a end user would not have had a single dom_webspeech.xpt file on his PC anyway.