Closed Bug 856370 Opened 7 years ago Closed 7 years ago
Remove VPATH from webspeech/Makefile
I think we decided to have separate modules for synthesis and recognition. We also talked about VPATH being generally bad.
Comment on attachment 731576 [details] [diff] [review] Add a Makefile.in in webspeech/recognition and remove webspeech top-level VPATH. I think you should add dom_webspeech.xpt to removed-files.in, and you could just move Makefile.in and moz.build to the new place and modify them there.
Attachment #731576 - Flags: review?(bugs) → review-
Comment on attachment 732548 [details] [diff] [review] Move webspeech/Makefile.in to recognition folder. Not sure you need #ifdef in removed-files.in
Attachment #732548 - Flags: review?(bugs) → review+
(In reply to Olli Pettay [:smaug] from comment #4) > Comment on attachment 732548 [details] [diff] [review] > Move webspeech/Makefile.in to recognition folder. > > Not sure you need #ifdef in removed-files.in Yeah, not sure why I would. I just saw it used elsewhere. I'll remove them.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Just a comment on the removed-files.in patch: I think this was not really needed as all .xpt files get merged into interfaces.xpt (inside omni.jar) or browser.xpt (when building without omni.jar) when packaging the installer/updater. So a end user would not have had a single dom_webspeech.xpt file on his PC anyway.
You need to log in before you can comment on or make changes to this bug.