Last Comment Bug 856409 - Fixed warnings in Accesibility.cpp
: Fixed warnings in Accesibility.cpp
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla22
Assigned To: Bindar Robert
:
Mentors:
Depends on:
Blocks: cleana11y 819664
  Show dependency treegraph
 
Reported: 2013-03-31 04:19 PDT by Bindar Robert
Modified: 2013-04-01 11:00 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (1.80 KB, patch)
2013-03-31 04:25 PDT, Bindar Robert
tbsaunde+mozbugs: review+
Details | Diff | Splinter Review
Patch v2 (1.84 KB, patch)
2013-03-31 13:42 PDT, Bindar Robert
tbsaunde+mozbugs: review+
Details | Diff | Splinter Review
Patch v3 (1.88 KB, patch)
2013-03-31 15:29 PDT, Bindar Robert
no flags Details | Diff | Splinter Review

Description Bindar Robert 2013-03-31 04:19:38 PDT
/home/student/mozilla-central/accessible/src/generic/Accessible.cpp: In member function ‘virtual bool mozilla::a11y::Accessible::InsertChildAt(uint32_t, mozilla::a11y::Accessible*)’:
/home/student/mozilla-central/accessible/src/generic/Accessible.cpp:2657:7: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/home/student/mozilla-central/accessible/src/generic/Accessible.cpp: In member function ‘virtual bool mozilla::a11y::Accessible::RemoveChild(mozilla::a11y::Accessible*)’:
/home/student/mozilla-central/accessible/src/generic/Accessible.cpp:2688:5: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
Comment 1 Bindar Robert 2013-03-31 04:20:34 PDT
This is my first bug, i will submit a patch soon.
Comment 2 Bindar Robert 2013-03-31 04:25:37 PDT
Created attachment 731630 [details] [diff] [review]
Patch v1
Comment 3 Trevor Saunders (:tbsaunde) 2013-03-31 11:24:41 PDT
Comment on attachment 731630 [details] [diff] [review]
Patch v1

you should use static_cast instead of C style cast

r=tbsaunde with that
Comment 4 Bindar Robert 2013-03-31 13:37:50 PDT
(In reply to Trevor Saunders (:tbsaunde) from comment #3)
> Comment on attachment 731630 [details] [diff] [review]
> Patch v1
> 
> you should use static_cast instead of C style cast
> 
> r=tbsaunde with that

Thanks for review, I will send now the new patch.
Comment 5 Bindar Robert 2013-03-31 13:42:51 PDT
Created attachment 731700 [details] [diff] [review]
Patch v2
Comment 6 Trevor Saunders (:tbsaunde) 2013-03-31 15:12:20 PDT
Comment on attachment 731700 [details] [diff] [review]
Patch v2

nit, keep lines under 80 chars
Comment 7 Bindar Robert 2013-03-31 15:29:30 PDT
Created attachment 731711 [details] [diff] [review]
Patch v3
Comment 8 Trevor Saunders (:tbsaunde) 2013-03-31 15:41:58 PDT
landed for you with nits fixed
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/8b2b844834b2
Comment 9 alexander :surkov 2013-03-31 18:55:35 PDT
(In reply to Bindar Robert from comment #1)
> This is my first bug, i will submit a patch soon.

congrats! thank you for the work (if you'd like to get another one you can consider these https://bugzilla.mozilla.org/buglist.cgi?list_id=6159856&resolution=---&query_based_on=mentored&status_whiteboard_type=substring&query_format=advanced&status_whiteboard=[mentor%3D&component=Disability%20Access%20APIs&product=Core&known_name=mentored)
Comment 10 Ryan VanderMeulen [:RyanVM] 2013-04-01 11:00:03 PDT
https://hg.mozilla.org/mozilla-central/rev/8b2b844834b2

Note You need to log in before you can comment on or make changes to this bug.