The default bug view has changed. See this FAQ.

Fixed warnings in Accesibility.cpp

RESOLVED FIXED in mozilla22

Status

()

Core
Disability Access APIs
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Bindar Robert, Assigned: Bindar Robert)

Tracking

(Blocks: 1 bug)

unspecified
mozilla22
x86_64
Linux
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

4 years ago
/home/student/mozilla-central/accessible/src/generic/Accessible.cpp: In member function ‘virtual bool mozilla::a11y::Accessible::InsertChildAt(uint32_t, mozilla::a11y::Accessible*)’:
/home/student/mozilla-central/accessible/src/generic/Accessible.cpp:2657:7: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/home/student/mozilla-central/accessible/src/generic/Accessible.cpp: In member function ‘virtual bool mozilla::a11y::Accessible::RemoveChild(mozilla::a11y::Accessible*)’:
/home/student/mozilla-central/accessible/src/generic/Accessible.cpp:2688:5: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
(Assignee)

Comment 1

4 years ago
This is my first bug, i will submit a patch soon.
(Assignee)

Comment 2

4 years ago
Created attachment 731630 [details] [diff] [review]
Patch v1
Attachment #731630 - Flags: review?(trev.saunders)

Updated

4 years ago
Blocks: 389800
Blocks: 819664
Comment on attachment 731630 [details] [diff] [review]
Patch v1

you should use static_cast instead of C style cast

r=tbsaunde with that
Attachment #731630 - Flags: review?(trev.saunders) → review+
(Assignee)

Comment 4

4 years ago
(In reply to Trevor Saunders (:tbsaunde) from comment #3)
> Comment on attachment 731630 [details] [diff] [review]
> Patch v1
> 
> you should use static_cast instead of C style cast
> 
> r=tbsaunde with that

Thanks for review, I will send now the new patch.
(Assignee)

Comment 5

4 years ago
Created attachment 731700 [details] [diff] [review]
Patch v2
Attachment #731630 - Attachment is obsolete: true
Attachment #731700 - Flags: review?(trev.saunders)
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Comment on attachment 731700 [details] [diff] [review]
Patch v2

nit, keep lines under 80 chars
Attachment #731700 - Flags: review?(trev.saunders) → review+
(Assignee)

Comment 7

4 years ago
Created attachment 731711 [details] [diff] [review]
Patch v3
Attachment #731700 - Attachment is obsolete: true
Attachment #731711 - Flags: review?(trev.saunders)
landed for you with nits fixed
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/8b2b844834b2
Keywords: checkin-needed
Attachment #731711 - Flags: review?(trev.saunders)

Updated

4 years ago
Assignee: nobody → bindarel
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Comment 9

4 years ago
(In reply to Bindar Robert from comment #1)
> This is my first bug, i will submit a patch soon.

congrats! thank you for the work (if you'd like to get another one you can consider these https://bugzilla.mozilla.org/buglist.cgi?list_id=6159856&resolution=---&query_based_on=mentored&status_whiteboard_type=substring&query_format=advanced&status_whiteboard=[mentor%3D&component=Disability%20Access%20APIs&product=Core&known_name=mentored)
https://hg.mozilla.org/mozilla-central/rev/8b2b844834b2
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.