Closed
Bug 856409
Opened 13 years ago
Closed 13 years ago
Fixed warnings in Accesibility.cpp
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: bindarel, Assigned: bindarel)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
|
1.88 KB,
patch
|
Details | Diff | Splinter Review |
/home/student/mozilla-central/accessible/src/generic/Accessible.cpp: In member function ‘virtual bool mozilla::a11y::Accessible::InsertChildAt(uint32_t, mozilla::a11y::Accessible*)’:
/home/student/mozilla-central/accessible/src/generic/Accessible.cpp:2657:7: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/home/student/mozilla-central/accessible/src/generic/Accessible.cpp: In member function ‘virtual bool mozilla::a11y::Accessible::RemoveChild(mozilla::a11y::Accessible*)’:
/home/student/mozilla-central/accessible/src/generic/Accessible.cpp:2688:5: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
|
Assignee | |
Comment 1•13 years ago
|
||
This is my first bug, i will submit a patch soon.
|
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #731630 -
Flags: review?(trev.saunders)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 731630 [details] [diff] [review]
Patch v1
you should use static_cast instead of C style cast
r=tbsaunde with that
Attachment #731630 -
Flags: review?(trev.saunders) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
(In reply to Trevor Saunders (:tbsaunde) from comment #3)
> Comment on attachment 731630 [details] [diff] [review]
> Patch v1
>
> you should use static_cast instead of C style cast
>
> r=tbsaunde with that
Thanks for review, I will send now the new patch.
|
|
Assignee | |
Comment 5•13 years ago
|
||
Attachment #731630 -
Attachment is obsolete: true
Attachment #731700 -
Flags: review?(trev.saunders)
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
|
||
Comment 6•13 years ago
|
||
Comment on attachment 731700 [details] [diff] [review]
Patch v2
nit, keep lines under 80 chars
Attachment #731700 -
Flags: review?(trev.saunders) → review+
|
|
Assignee | |
Comment 7•13 years ago
|
||
Attachment #731700 -
Attachment is obsolete: true
Attachment #731711 -
Flags: review?(trev.saunders)
|
|
||
Comment 8•13 years ago
|
||
landed for you with nits fixed
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/8b2b844834b2
|
|
||
Updated•13 years ago
|
Keywords: checkin-needed
|
|
||
Updated•13 years ago
|
Attachment #731711 -
Flags: review?(trev.saunders)
|
||
Updated•13 years ago
|
Assignee: nobody → bindarel
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
|
||
Comment 9•13 years ago
|
||
(In reply to Bindar Robert from comment #1)
> This is my first bug, i will submit a patch soon.
congrats! thank you for the work (if you'd like to get another one you can consider these https://bugzilla.mozilla.org/buglist.cgi?list_id=6159856&resolution=---&query_based_on=mentored&status_whiteboard_type=substring&query_format=advanced&status_whiteboard=[mentor%3D&component=Disability%20Access%20APIs&product=Core&known_name=mentored)
|
||
Comment 10•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•