856598 - ./checksetup.pl should exit(1) if it fails checks

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, enhancement)

Description

[Christian Höltje]

What happens:

If you have a bugzilla setup that is missing configurations, etc. (e.g. you don't have the right password for the database in localconfig) and you run './checksetup.pl' it will quit with exit code 0.

What I expected:

'./checksetup.pl' should return a non-zero exit code.

Notes:

This makes scripting the checksetup.pl possible.  Which is useful for controlled deploying of bugzilla.

The fix is to change the following line:

diff --git a/checksetup.pl b/checksetup.pl
index 6d9230d..65c4fd7 100755
--- a/checksetup.pl
+++ b/checksetup.pl
@@ -86,7 +86,7 @@ exit if $switch{'version'};
 my $module_results = check_requirements(!$silent);
 Bugzilla::Install::Requirements::print_module_instructions(
     $module_results, !$silent);
-exit if !$module_results->{pass};
+exit(1) if !$module_results->{pass};
 # Break out if checking the modules is all we have been asked to do.
 exit if $switch{'check-modules'};

Comment 1

[Christian Ruppert]

Attachment: 0001-Fix-some-exit-values.patch

This patch should help.

Comment 2

[Gervase Markham [:gerv]]

Comment on attachment 8366796 [details] [diff] [review]
0001-Fix-some-exit-values.patch

r=gerv. Thanks for the patch, Christian :-) For future reference, it's good to request review on your patches, otherwise no-one may notice them!

Gerv

Comment 3

[Gervase Markham [:gerv]]

To ssh://[e-mail]/bugzilla/bugzilla.git
   2b7da8b..f0f5194  master -> master

Christian: thanks again, and sorry for the delay. Please do continue to contribute to Bugzilla :-)

Gerv