856736 - Set X-Bugzilla-Type to dep_changed for 'dependency changed" bugmail

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, enhancement)

Description

[Kartikaya Gupta (email:[e-mail])]

Recently (in the last 3-4 days or so) emails from bugzilla.mozilla.org about dependent bug changes have started including the field names in the X-Bugzilla-Changed-Fields and X-Bugzilla-Changed-Field-Names headers. For example, bug 856039 was recently closed, and I got a notification email for bug 814282 which depends on bug 856039. The notification email contained:

X-Bugzilla-Changed-Fields: Status Resolution
X-Bugzilla-Changed-Field-Names: bug_status resolution
[snip other headers]

https://bugzilla.mozilla.org/show_bug.cgi?id=814282

Bug 814282 depends on bug 856039, which changed state.

Bug 856039 Summary: Don't let bounce animations clobber viewport size updates
https://bugzilla.mozilla.org/show_bug.cgi?id=856039

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED



I'm not sure if this change was intentional but email filters that filtered on the Changed-Fields headers are now affected (in my case, for the worse). If it wasn't intentional I would like this to be reverted.

Comment 1

[David Lawrence [:dkl]]

There has been a change recently to the code that generates the email headers so this could be possible. I am looking now to see how this affects dependency emails. 

http://bzr.mozilla.org/bmo/4.2/revision/8695

dkl

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Any update on this?

Comment 3

[David Lawrence [:dkl]]

You wouldn't by chance have an old email that did not show this problem before the code change? 

I need something to compare to. I could revert the patch locally and see but I thought you may have something quicker.

Thanks
dkl

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Old email

Sure, I've attached an old email from before the change.

Comment 5

[David Lawrence [:dkl]]

Ok so I found the place where we fixed this in the code and therefore changed your email headers to be different than before.

http://bzr.mozilla.org/bmo/4.2/revision/8687

It was not related to the header change we did recently and was instead a bug fix where it was causing our logs to fill up with warnings. 

The header "X-Bugzilla-Changed-Fields:" was there before our upgrade on 3/5 to Bugzilla 4.2 but was blank unintentionally for dependency emails. We were not populating the field description values properly. After the fix on 3/25 the "Status Resolution" values are now being displayed properly. 

The fact that you were filtering on the original empty X-Bugzilla-Changed-Fields: header was unfortunate but not our intention.

Instead what I propose is we issue a proper header for dependency changes so you will have something better and more stable to filter on. 

Currently we have:

X-Bugzilla-Type: changed 

for both normal bug change notifications and dependency notifications. I propose we change the X-Bugzilla-Type header to show dep_changed when it is a dependency notification like the one you pasted in comment 0:

X-Bugzilla-Type: dep_changed

We should push this upstream as well if possible.

glob, opinion?

dkl

Comment 6

[:glob ✱]

+1 setting x-bugzilla-type to dep_changed makes a lot of sense.

Comment 7

[David Lawrence [:dkl]]

Attachment: 856736_1.patch

Comment 8

[David Lawrence [:dkl]]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk
modified Bugzilla/BugMail.pm
modified template/en/default/email/bugmail-header.txt.tmpl
Committed revision 8676.

Comment 9

[Frédéric Buclin]

Added to relnotes for 5.0rc1.