Closed
Bug 856752
Opened 13 years ago
Closed 13 years ago
Reinstate Node.hasAttributes
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla23
| Tracking | Status | |
|---|---|---|
| firefox21 | --- | unaffected |
| firefox22 | + | fixed |
| firefox23 | + | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
(Keywords: site-compat)
Attachments
(1 file)
|
113.33 KB,
patch
|
khuey
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
I think we should back out bug 849661 until such a time as it can be done properly (with a deprecation period, and better compat testing).
Sadly, we have to do this on Aurora too because people sat on it too long.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #731980 -
Flags: review?(khuey)
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → bzbarsky
|
|
||
Updated•13 years ago
|
status-firefox21:
--- → unaffected
status-firefox22:
--- → affected
status-firefox23:
--- → affected
Comment on attachment 731980 [details] [diff] [review]
Reinstate Node.hasAttributes.
Review of attachment 731980 [details] [diff] [review]:
-----------------------------------------------------------------
Ugh
Attachment #731980 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Flags: in-testsuite+
Target Milestone: --- → mozilla23
|
|
Assignee | |
Comment 4•13 years ago
|
||
Comment on attachment 731980 [details] [diff] [review]
Reinstate Node.hasAttributes.
[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 849661
User impact if declined: Possible site compat issues
Testing completed (on m-c, etc.): Seems to pass tests
Risk to taking this patch (and alternatives if risky): Risk is low; this is
basically just a backout.
String or IDL/UUID changes made by this patch: Lots and lots of UUID changes for
all Node subclasses.
Attachment #731980 -
Flags: approval-mozilla-aurora?
|
||
Updated•13 years ago
|
|
|
||
Updated•13 years ago
|
Keywords: site-compat
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 6•13 years ago
|
||
Unobsoleted https://developer.mozilla.org/en-US/docs/DOM/Node.hasAttributes
Not changing https://developer.mozilla.org/en-US/docs/Firefox_22_for_developers yet since we haven't gotten this on Aurora so far.
|
|
||
Comment 7•13 years ago
|
||
(In reply to Boris Zbarsky (:bz) from comment #4)
> String or IDL/UUID changes made by this patch: Lots and lots of UUID changes
> for all Node subclasses.
This is OK, since Aurora does not have the same requirements as Beta/Release, and we won't be enabling updates for Aurora 22 till Friday.
|
|
Assignee | |
Comment 8•13 years ago
|
||
Right; I was figuring it's ok, hence the approval request. ;)
|
|
||
Comment 9•13 years ago
|
||
Comment on attachment 731980 [details] [diff] [review]
Reinstate Node.hasAttributes.
Forgot the a+, sorry bz.
Attachment #731980 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
||
Comment 10•13 years ago
|
||
|
|
||
Comment 11•13 years ago
|
||
Removed the mentions about Node.hasAttributes from the docs:
https://developer.mozilla.org/en-US/docs/Firefox_22_for_developers
https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_22
Keywords: dev-doc-needed
|
|
Assignee | |
Comment 12•13 years ago
|
||
Kohei Yoshino, thank you!
|
||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•