856755 - Keyboard is prone to crash on Xperia devices

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

These keyboard crashes are not caught by the crash reporter, but I do have a patch to make it not crash.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Return SpannableString or String in extracted text (v1)

The custom keyboard on Xperia expects specific object types for extracted text

Comment 2

[Chris Peterson [:cpeterson]]

Comment on attachment 731985 [details] [diff] [review]
Return SpannableString or String in extracted text (v1)

Review of attachment 731985 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/90aa2c55421c

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 731985 [details] [diff] [review]
Return SpannableString or String in extracted text (v1)

[Approval Request Comment]

Bug caused by (feature/regressing bug #): N/A

User impact if declined: Keyboard crashes when using Fennec on Xperia devices; impact is unclear because these crashes cannot be caught by Crash Reporter

Testing completed (on m-c, etc.): Locally

Risk to taking this patch (and alternatives if risky): Very small; the patch only affects the crash

String or IDL/UUID changes made by this patch: None

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/90aa2c55421c

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 731985 [details] [diff] [review]
Return SpannableString or String in extracted text (v1)

Since we're early in the beta cycle, this is low risk, and we don't know the total user impact, approving for branches.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3c725dc175a9
https://hg.mozilla.org/releases/mozilla-beta/rev/e96d740f3dc9