Closed Bug 856757 Opened 9 years ago Closed 9 years ago

Remove unused broken dialog code from metro/components/LoginManagerPrompter.js

Categories

(Firefox for Metro Graveyard :: Components, defect)

All
Windows 8.1
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 23

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
LoginManagerPrompter has two ways to display notifications: a notification bar, or a dialog for cases where the notification bar is not available.

As far as I know, the dialog code is never used in Metro, and is broken (because our locale file doesn't have the strings it needs).  I think we can remove it.
Attachment #731983 - Flags: review?(netzen)
Comment on attachment 731983 [details] [diff] [review]
patch

Review of attachment 731983 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think it's used.
Attachment #731983 - Flags: review?(netzen) → review+
https://hg.mozilla.org/mozilla-central/rev/c6dc0ad3fd42
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.