Closed
Bug 856757
Opened 11 years ago
Closed 11 years ago
Remove unused broken dialog code from metro/components/LoginManagerPrompter.js
Categories
(Firefox for Metro Graveyard :: Components, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 23
People
(Reporter: mbrubeck, Assigned: mbrubeck)
Details
Attachments
(1 file)
6.68 KB,
patch
|
bbondy
:
review+
|
Details | Diff | Splinter Review |
LoginManagerPrompter has two ways to display notifications: a notification bar, or a dialog for cases where the notification bar is not available. As far as I know, the dialog code is never used in Metro, and is broken (because our locale file doesn't have the strings it needs). I think we can remove it.
Attachment #731983 -
Flags: review?(netzen)
Comment 1•11 years ago
|
||
Comment on attachment 731983 [details] [diff] [review] patch Review of attachment 731983 [details] [diff] [review]: ----------------------------------------------------------------- I don't think it's used.
Attachment #731983 -
Flags: review?(netzen) → review+
Assignee | ||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c6dc0ad3fd42
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c6dc0ad3fd42
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•