Closed Bug 856818 Opened 11 years ago Closed 11 years ago

Land some version of attachment 730820 [details] [diff] [review]

Categories

(Core :: XPConnect, defect)

Product:
Core
Component:
XPConnect
Version:
22 Branch
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: mrbkap, Unassigned)

Details

+++ This bug was initially created as a clone of Bug #852436 +++

Attachment 730820 [details] [diff] clears mJSObject for outer windows when the object is GC'd. I was worried that simply clearing it would cause bad things to happen if someone (e.g.) calls EnsureScriptEnvironment on an already-closed window (where mJSObject would be non-null). The current situation doesn't crash because we do clear the version of the object in the wrapper cache.

So, we need to make sure that calling EnsureScriptEnvironment on a closed window is OK (since it happens, the current patch asserted that it didn't) and land the patch.
We now poison mJSObject.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.