856863 - [B2G][Homescreen] Moving icons to a Dock caused them to freeze misaligned

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Natalya Kot [:nkot]]

Description:
When the user attempts to move icons from the grid to a docked position,the icons freeze in a misaligned position. Docked icons move, allowing space for the dropped icon, but the icons do not move back if the user does not drop icons into the space.

Repro Steps:
1) Updated to Unagi Build ID: 20130401070203
2) Launch homescreen
3) Longpress any app icon to enter into edit mode
4) Holding icon move it to the right corner of the Dock w/o dropping
5) Let the Dock expand creating extra space for new icon
6) Still holding icon move it back to the grid
7) Tap the home button to save changes

Actual:
Icons in the Dock freeze misaligned with empty space between icons

Expected:
The Dock expands allowing space to drop an additional icon and adjusts accordingly if the icon was not dropped

Environmental  Variables:
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/f9f11b8cbf8a
Gaia: 663101b6eb809383e5882d9bc3868a923a57998a

Notes:
See attached video clip for more info  http://youtu.be/HzV2njXISMk

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 2

[Wayne Chang [:wchang]]

Triage 4/2 - setting leo+ due to poor user experience/presentation

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 732273 [details]
Patch v1

r+ but please find an other name for rePlace. Written like that is seems like a typo on a method call replace. :)

Comment 4

[Cristian Rodriguez (:crdlc)]

yes, sure, thanks a lot my friend

Comment 5

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/ea77a2751710d6c0bb46cd6f91ae8c10b88fa319

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 ea77a2751710d6c0bb46cd6f91ae8c10b88fa319
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 7

[Cristian Rodriguez (:crdlc)]

I gonna try to solve conflicts during morning

Comment 8

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/2b8605cc9d210ae7ccaed435d8957855e69cdc77

Comment 9

[Natalya Kot [:nkot]]

Verifying fix, issue does not reproduce anymore,
- if the user attempts to move the icon to a dock but does not drop it there, dock expands to allow space for a dropped icon and then successfully resumes to normal state if the icon was not dropped into the space

tested on Unagi running the following build:
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/24b27125d907
Gaia   b973e66f328d8e09e364654e17ddab9f2c938bc4
Build  2013-04-08-07-57-51

also confirming V1.0.1 is not affected,
could not reproduce this issue
tested with:
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/3b51ced33215
Gaia:  8cf8dbd430af5e72a2ad542824421debe6de29d4