Closed Bug 856888 Opened 12 years ago Closed 7 years ago

The links provided in notes in the read only view are not clickable


(Firefox OS Graveyard :: Gaia::Calendar, defect)

Gonk (Firefox OS)
Not set


(b2g18+, b2g-master affected)

Tracking Status
b2g18 + ---
b2g-master --- affected


(Reporter: jsmith, Assigned: vladimir.smirnov2)



(Keywords: feature, Whiteboard: [UX-P?], ux-tracking, 2.6UXnom)


(2 files)

If an event is viewed that contains links in the notes, we should allow those links to be clickable. Right now, they aren't, which makes accessing a URL from a calendar event a rough user experience - you'll have to memorize the URL or write it down, move to the browser, and type it in.

Let's make those links clickable in the read only view.
Technically I'd more call this a UX feature, but let's see what UX thinks how important this is. I personally found this quite annoying that this doesn't exist, as my work calendar contains links in the events.
Flags: needinfo?(rmacdonald)
Whiteboard: [UX-P?]
Yes, the links should be clickable. As a starting point this includes both URLs and emails. If feasible, it should also include phone numbers (initiate dialer).

There's also the issue of attachments. In this case we should launch the related viewer as per This may be beyond the scope of the current feature, though, so I'll add a needs info for Peter Dolanjski.
Flags: needinfo?(rmacdonald) → needinfo?(pdolanjski)
It is certainly a good suggestion and tablestakes functionality.  We can't consider such a new feature for the imminent releases, but I'd like to understand how much effort would be involved to enable urls, email addresses and phone numbers, in particular.

Ben, would you be the right individual to comment on this?

One approach would be to only make these clickable when proper html href attributes are used.  Another option would be to parse the body for recognizable links.
Flags: needinfo?(pdolanjski) → needinfo?(bfrancis)
Re-posting link to patterns document as dropbox link seems to have been broken...
I don't know much about how the calendar currently behaves when it encounters HTML content, I suggest asking James.
Flags: needinfo?(bfrancis) → needinfo?(jlal)
We have code for this in the email app which we can-reuse more globally. Handling html descriptions is much more difficult because we need to deal with sanitizing the html but again email handles this now.
Flags: needinfo?(jlal)
re-nominating for leo? This is a very simple to implement feature and we can re-use email's implementation and continue to improve it over time.
blocking-b2g: --- → leo?
Please nominate for uplift to v1.1 once resolved, but not a blocker.
blocking-b2g: leo? → -
tracking-b2g18: --- → +
Assignee: nobody → evanxd
Depends on: 847715
blocking-b2g: - → backlog
blocking-b2g: backlog → ---
Keywords: feature
Assignee: evanxd → nobody
Whiteboard: [UX-P?] → [UX-P?], ux-most-wanted
Blocks: 1096847
Blocks: 994991
ux-b2g: --- → 2.2
Whiteboard: [UX-P?], ux-most-wanted → [UX-P?], ux-most-wanted-nov2014
Whiteboard: [UX-P?], ux-most-wanted-nov2014 → [UX-P?], ux-most-wanted-nov2014, 2x-uxnom
Adding qawanted - is this still an issue?
ux-b2g: 2.2 → ---
Keywords: qawanted
Whiteboard: [UX-P?], ux-most-wanted-nov2014, 2x-uxnom → [UX-P?], ux-tracking
If I understand this bug correctly, this is still reproducible on latest Aries.

What I did:
1) Open Calendar, and create an event (online with an account or offline does not matter)
2) During event creation, make sure to add an URL like in the Notes section down below. Finish creating the event.
3) Back in Calendar view, tap to view the event in detail created at step 1/step 2
4) Attempt to tap on the link and see if it's tappable

Result: It is not tappable. See screenshot.

Tested and occurred on:
Device: Aries
BuildID: 20151123143009
Gaia: bae13c9ac6a91beecd7c94384e2aef25ed1a3214
Gecko: d3d286102ba7f8801e9dfe12d534f49554ba50c0
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6 Master) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(jmercado)
Keywords: qawanted
Tiffanie it seems this is still an issue.  It was never a blocker before, not sure if you consider it more important now than they did back when the bug was written.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(jmercado) → needinfo?(tshakespeare)
Thanks so much guys! Just trying to go through old bugs and get them organized :)
Flags: needinfo?(tshakespeare)
Whiteboard: [UX-P?], ux-tracking → [UX-P?], ux-tracking, 2.6UXnom
Comment on attachment 8696954 [details] [review]
[gaia] ruvsmirnov:bug-856888-calendar-notes-links-clickable-provided > mozilla-b2g:master

Gareth, could you please review the patch?
Attachment #8696954 - Flags: review?(gaye)
Assignee: nobody → vladimir.smirnov2
Gareth, I leave comment on this patch. Could you please see it?
Comment on attachment 8696954 [details] [review]
[gaia] ruvsmirnov:bug-856888-calendar-notes-links-clickable-provided > mozilla-b2g:master

I left some ocmments on github already. Especially I'm fine moving link_helper to shared, but not activity_picker. I think integrating the 3 types of link into link_action_handler would be better, especially that the existing activity_picker contains activities that are useful in SMS but not in Calendar. (and it also is quite outdated nowadays).

adding the r? to myself so that I can check on a device.
Attachment #8696954 - Flags: review?(felash)
Comment on attachment 8696954 [details] [review]
[gaia] ruvsmirnov:bug-856888-calendar-notes-links-clickable-provided > mozilla-b2g:master

OK this seems to work for me, but I'd still prefer that we follow my previous comment.

Thanks !
Attachment #8696954 - Flags: review?(felash) → review-
Firefox OS is not being worked on
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.