856911 - Decide on a consistent representation for non-nullable JSObject in bindings code

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Right now it's JSObject* for callback interface arguments and normal binding return values, but JSObject& for normal binding arguments.  This is making it kinda hard to do "object" in JS-implemented interfaces.

My temptation, honestly, would be to standardize on JSObject& for non-nullable, and make things work for return values by using NonNull cleverly.

Thoughts?

Comment 1

[Andrew McCreight [:mccr8]]

Sounds reasonable.  & enforces the non-nullness more heavily.

I don't know what you mean by "make things work for return values by using NonNull cleverly", though.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Oh, because return values, even non-null ones, are probably going to stay JSObject*, so we need the "wrapping" code to handle both that and JSObject&.  Though maybe we should just make non-null object values JSObject& as well and be done with it?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Fixed by the patch in bug 868715; now it's all Handle<JSObject*> for arguments.