857031 - pdf.js performance on an ice map is not acceptable

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, enhancement, P1)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: test

Looks like there are many layers in the map. Pdf.js really can't handle this too well.
Other pdf viewers seem to behave significantly faster.

Comment 1

[Nicholas Nethercote [inactive]]

How slow is slow? It takes about 4--5 seconds to render for me, which isn't so bad for a detailed vector map like this one.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Compare to native pdf viewers. Especially zoom level changes are painful.

Comment 3

[Nicholas Nethercote [inactive]]

Redrawing after zoom takes about 1.5s for me. evince takes about 0.5s.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Redraw after zoom takes ~3s here.
Evince doesn't seem to really redraw. Is just scales + does some antialiasing.

Comment 5

[Marco Castelluccio [:marco]]

I think this regressed, it's way slower than a few seconds.

Comment 6

[Brendan Dahl [:bdahl]]

Still pretty quick on MacOS: 2159ms for page 1.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

It is pretty ok on Linux. And zoom is around the same level what gnome's native pdf viewer has.

Comment 8

[Marco Castelluccio [:marco]]

Weird, on my Linux machine it takes around 20 seconds.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Worth to profile?

Comment 10

[Marco Castelluccio [:marco]]

https://share.firefox.dev/35wv06i

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

hmm, that profile misses quite a bit details. Was it recorded using WebDev settings or what?
But anyhow, canvas is taking almost all the time.

The profile I got is quite different https://share.firefox.dev/3HkKDvK.
Canvas code is taking way less time (vs other stuff happening)

Comment 12

[Kenan]

On Win10 it takes about 10sec+ to load and render.
https://share.firefox.dev/3g9jlMJ

Comment 13

[Marco Castelluccio [:marco]]

Here's a better profile: https://share.firefox.dev/32NWPWK.

Comment 14

[Olli Pettay [:smaug][[e-mail]]]

Let me put this to performance triage, that way also the performance flag will be set.

This is better these days, but still not great.

Comment 15

[Benjamin De Kosnik [:bdekoz]]

Can reproduce on mac, linux, windows. Significant difference from Chrome on speed. P1 performance page load.

Comment 17

[Marco Castelluccio [:marco]]

(In reply to Benjamin De Kosnik [:bdekoz] from comment #15)

Can reproduce on mac, linux, windows. Significant difference from Chrome on speed. P1 performance page load.

I imagine you meant to set the Performance field to P1 and not change the Priority field.

Comment 18

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pdf.js/pull/14754

Comment 19

[Marco Castelluccio [:marco]]

Can we add this PDF to the set of PDFs we use for performance/memory tests?

Comment 20

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub master push: https://github.com/mozilla/pdf.js/commit/08e1abe68e5df09c753665739e09c4529e1f6e61

Commit merged into master by GitHub
Authored by calixteman (calixteman)

Comment 21

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pdf.js/pull/14777

Comment 22

[Calixte Denizet (:calixte)]

Attachment: Bug 857031 - Add a performance test for the rendering of a pdf with a lot of image masks r=#pdfjs-reviewers

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/666e6f622fa6
Add a performance test for the rendering of a pdf with a lot of image masks r=pdfjs-reviewers,perftest-reviewers,marco,sparky DONTBUILD

Comment 24

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/666e6f622fa6

Comment 25

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub master push: https://github.com/mozilla/pdf.js/commit/379125c37ff58cfb86e3bbd2eca5760fb2fcb061

Commit merged into master by GitHub
Authored by calixteman (calixteman)

Comment 26

[Marco Castelluccio [:marco]]

This is not instantaneous like in Evince, but I think it's fast enough now.