Closed Bug 857242 Opened 8 years ago Closed 8 years ago

Make profiler verbosity on desktop be runtime-selectable

Categories

(Core :: Gecko Profiler, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: jseward, Assigned: jseward)

References

Details

Attachments

(1 file)

Bug 850833 disables SPS-side logging on desktop, requiring a rebuild
with SPS_FORCE_LOG set to turn it back on.  This makes it difficult to
diagnose unwinder failures in nightly builds.

Hence, get rid of SPS_FORCE_LOG, and add another environment variable
MOZ_PROFILER_VERBOSE, which when set causes the old level of logging
to be resumed.  When unset (the default) the profiler remains at its
post-850833 level of verbosity.
Attached patch PatchSplinter Review
Attachment #732697 - Flags: review?(bgirard)
Attachment #732697 - Flags: review?(bgirard) → review+
https://hg.mozilla.org/mozilla-central/rev/b56d762d3511
Assignee: nobody → jseward
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Blocks: 863453
You need to log in before you can comment on or make changes to this bug.