857244 - [B2G][Contacts] Unable to import Facebook contacts

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Mila Davydova]

Attachment: Logcat

Description:
User is not able to import Facebook contacts.  After entering Facebook credentials user is not taken to the Facebook contacts list view to import selected contacts 

Repro Steps:
1) Updated to Unagi Build ID: 20130402070202
2) Go to the Contacts app
3) Tap on the "Settings" button
4) Toggle the "Facebook" button 
5) Enter the Facebook credentials 
6) Tap on the Login button 

Actual:
Facebook contacts do not get loaded and user is taken back to the Contacts Settings page instead of Facebook contacts page. 

Expected:
User is taken to the Facebook contacts page and able to import selected Facebook contacts

Environmental  Variables:
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/ccec751a468e
Gaia: ee0bef61c0a25c806dd1eec5a4e047bc418a5f73

Notes:
Repro frequency: 100% on multiple Unagi devices
Q Analysts Test Team Priority: Pri 3
See attached logcat for more info.
This is a regression and only reproduces with b2g18_v1_0_1 build

Comment 1

[Cristian Rodriguez (:crdlc)]

Regression here:

https://github.com/mozilla-b2g/gaia/commit/f0bccacb4324ca862d10b819281168302e66e610#L2R192

E/GeckoConsole( 3849): [JavaScript Error: "ReferenceError: targetApp is not defined" {file: "app://communications.gaiamobile.org/contacts/gaia_build_defer_fb_import.js" line: 290}]

Please German take a look

Comment 2

[Cristian Rodriguez (:crdlc)]

This bug will be resolved by German's patch in order to solve the regression and my patch implemented in the bug 854397

Comment 3

[Germán Toro del Valle (:gtorodelvalle)]

My branch with the patch: https://github.com/gtorodelvalle/gaia/tree/v1.0.1-dialer-bug-857244-targetApp-problem

The commit including the patch: https://github.com/gtorodelvalle/gaia/commit/4a1a9921919ec6b6f513ebaa09c78f9dd447f904

Would you be so kind Cristian to have a look at it and test it before landing it in v1.0.1? Thanks!

Comment 4

[Cristian Rodriguez (:crdlc)]

Please add the patch here, when it will be tef+ we could land it, before not :) Then please, add the patch and ask me for review

Comment 5

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Patch solving the issue.

Comment 6

[Cristian Rodriguez (:crdlc)]

Comment on attachment 732729 [details] [diff] [review]
Patch solving the issue.

Perfect!

Comment 7

[Germán Toro del Valle (:gtorodelvalle)]

Link to the PR: https://github.com/mozilla-b2g/gaia/pull/8966

Comment 8

[Germán Toro del Valle (:gtorodelvalle)]

Landed in v1.0.1:
  - https://github.com/mozilla-b2g/gaia/commit/71c44c595299999e6c92776541c67f6d240416ff

Comment 9

[Cristian Rodriguez (:crdlc)]

After landing this patch and this one [1] the bug has been fixed. Re-open please if you can reproduce the problem.

Thanks

[1] https://github.com/mozilla-b2g/gaia/commit/daea430624ec02f8d36a12d581fc4a3278c27cb7

Comment 10

[Mila Davydova]

The issue is fixed on Unagi Build ID: 20130404070204
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/e43e65ec89d2
Gaia: daea430624ec02f8d36a12d581fc4a3278c27cb7

User is able to import selected Facebook contacts to the Contacts app.
Verified Fixed