857250 - GCC 4.8 warning: Ion.cpp:321:39: warning: typedef 'MoveOperand' locally defined but not used [-Wunused-local-typedefs]

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Daniel Holbert [:dholbert]]

js/src/ion/Ion.cpp:321:39: warning: typedef 'MoveOperand' locally defined but not used [-Wunused-local-typedefs]

The warning is for this chunk of code:
318 IonCode *
319 IonCompartment::getVMWrapper(const VMFunction &f)
320 {
321     typedef MoveResolver::MoveOperand MoveOperand;
322 
323     JS_ASSERT(rt->functionWrappers_);
324     JS_ASSERT(rt->functionWrappers_->initialized());
325     IonRuntime::VMWrapperMap::Ptr p = rt->functionWrappers_->readonlyThreadsafeLookup(&f);
326     JS_ASSERT(p);
327 
328     return p->value;
329 }
https://mxr.mozilla.org/mozilla-central/source/js/src/ion/Ion.cpp#318

hg blame says this typedef was added here:
 https://hg.mozilla.org/mozilla-central/rev/6ba78023b367#l2.189
and it looks like it was already unused at the time.  (Probably just copypasted boilerplate or something.)

Anyway, looks like it can be removed.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix: remove typedef

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 732467 [details] [diff] [review]
fix: remove typedef

Oops, apparently I forgot to request review.

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4b9d6e04de88

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4b9d6e04de88