The default bug view has changed. See this FAQ.

crash in mozilla::a11y::XULTextFieldAccessible::FrameSelection

RESOLVED FIXED in mozilla25

Status

()

Core
Disability Access APIs
--
critical
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: wsmwk, Assigned: poiru)

Tracking

({crash})

unspecified
mozilla25
x86
Windows 7
crash
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=trev.saunders@gmail.com][lang=c++][tbird crash], crash signature)

Attachments

(1 attachment)

This bug was filed from the Socorro interface and is 
report bp-ed693f70-c819-46a2-a97a-d64872130328 .
============================================================= 
0 	xul.dll 	mozilla::a11y::XULTextFieldAccessible::FrameSelection 	accessible/src/xul/XULFormControlAccessible.cpp:847
1 	xul.dll 	HyperTextAccessible::GetCaretOffset 	accessible/src/generic/HyperTextAccessible.cpp:1587
2 	xul.dll 	nsCaretAccessible::NormalSelectionChanged 	accessible/src/base/nsCaretAccessible.cpp:235
3 	xul.dll 	nsCaretAccessible::ProcessSelectionChanged 	accessible/src/base/nsCaretAccessible.cpp:211
4 	xul.dll 	NotificationController::HandleNotification<nsCaretAccessible,nsISelection> 	accessible/src/base/NotificationController.h:143
5 	xul.dll 	nsCaretAccessible::NotifySelectionChanged 	accessible/src/base/nsCaretAccessible.cpp:196
6 	xul.dll 	mozilla::Selection::NotifySelectionListeners 	layout/generic/nsSelection.cpp:5413
7 	xul.dll 	nsFrameSelection::NotifySelectionListeners 	layout/generic/nsSelection.cpp:2037
8 	xul.dll 	nsFrameSelection::SetMouseDownState 	layout/generic/nsSelection.cpp:1697
9 	xul.dll 	nsFrame::HandleRelease 	layout/generic/nsFrame.cpp:3146
10 	xul.dll 	nsFrame::HandleEvent 	layout/generic/nsFrame.cpp:2378
11 	xul.dll 	nsPresShellEventCB::HandleEvent 	layout/base/nsPresShell.cpp:505
12 	xul.dll 	nsEventTargetChainItem::HandleEventTargetChain 	content/events/src/nsEventDispatcher.cpp:363
Component: Disability Access → Disability Access APIs
Product: Thunderbird → Core
Version: 20 → unspecified
My guess is that GetInput() is returning null for some reason but I have no idea why

Updated

4 years ago
OS: Windows NT → Windows 7

Comment 2

4 years ago
(In reply to Trevor Saunders (:tbsaunde) from comment #1)
> My guess is that GetInput() is returning null for some reason but I have no
> idea why

same, null check + assertion = hoping we will catch it one day
Whiteboard: [good first bug][mentor=trev.saunders@gmail.com][lang=c++]
(Reporter)

Updated

4 years ago
Whiteboard: [good first bug][mentor=trev.saunders@gmail.com][lang=c++] → [good first bug][mentor=trev.saunders@gmail.com][lang=c++][tbird crash]

Comment 3

4 years ago
Hi I am interested in working on this bug,but it's my first time to work on with debug,can anybody guide me on how to get started with it?Thanks a lot.
(In reply to MikeLing from comment #3)
> Hi I am interested in working on this bug,but it's my first time to work on
> with debug,can anybody guide me on how to get started with it?Thanks a lot.
Flags: needinfo?(trev.saunders)

Comment 5

4 years ago
Hi tbsaunde,

I would like to know more about this bug and how can I go about fixing it. Can you get me started here?
(In reply to Anand Soni from comment #5)
> Hi tbsaunde,
> 
> I would like to know more about this bug and how can I go about fixing it.
> Can you get me started here?

In XULTextFieldAccessible::FrameSelection() you need to check if GetInput() returned null and return null before getting the frame if it did.
Flags: needinfo?(trev.saunders)
(Assignee)

Comment 7

4 years ago
Created attachment 766247 [details] [diff] [review]
First patch
Attachment #766247 - Flags: review?(trev.saunders)
(Assignee)

Comment 8

4 years ago
(In reply to Trevor Saunders (:tbsaunde) from comment #6)
> In XULTextFieldAccessible::FrameSelection() you need to check if GetInput()
> returned null and return null before getting the frame if it did.

Hi. I attached a patch to do exactly this. I also added an assertion as per comment #2.
Attachment #766247 - Flags: review?(trev.saunders) → review+
Keywords: checkin-needed

Comment 9

4 years ago
Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/df3ad1eb9ebb

Thanks for the patch!
Assignee: nobody → birunthan
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/df3ad1eb9ebb
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.