Hide HTMLInputElement's inputMode API behind a pref and only turn it on for Aurora/Nightly

VERIFIED FIXED in Firefox 21

Status

()

Core
DOM
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: Ehsan, Assigned: mounir)

Tracking

({dev-doc-complete, site-compat})

Trunk
mozilla23
dev-doc-complete, site-compat
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox21+ verified, firefox22+ verified, firefox23+ verified)

Details

Attachments

(1 attachment)

See the discussion in bug 850346.
(Assignee)

Updated

4 years ago
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Comment 1

4 years ago
Created attachment 742845 [details] [diff] [review]
Patch

Passed try: https://tbpl.mozilla.org/?tree=Try&rev=e06ebfad4782
Assignee: nobody → mounir
Status: NEW → ASSIGNED
Attachment #742845 - Flags: review?(bugs)
(Assignee)

Comment 2

4 years ago
We should ideally push that to Aurora and Beta to reduce the exposition of this attribute.
status-firefox21: --- → affected
status-firefox22: --- → affected
status-firefox23: --- → affected
tracking-firefox21: --- → ?
tracking-firefox22: --- → ?
tracking-firefox23: --- → ?

Updated

4 years ago
Attachment #742845 - Flags: review?(bugs) → review+

Comment 3

4 years ago
Is 21 really affected by bug 850346? Why are we backing this out (or preffing this off) only in time for the last Beta if FF21 is affected?
tracking-firefox22: ? → +
tracking-firefox23: ? → +
(Assignee)

Comment 4

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/68869162af7c

bug 850346 doesn't have much to do with that, I'm not sure what you are trying to ask here.
(Assignee)

Updated

4 years ago
Flags: in-testsuite+
Target Milestone: --- → mozilla23
(Assignee)

Comment 5

4 years ago
Comment on attachment 742845 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): bug 746142
User impact if declined: some websites might use the feature and got broken later
Testing completed (on m-c, etc.): just landed in m-i, tests are in m-c
Risk to taking this patch (and alternatives if risky): we should push this patch ASAP to release so we reduce the chances of having anyone using this feature before it is ready to be used.
String or IDL/UUID changes made by this patch: changed HTMLInputElement.webidl, no UUID changes.
Attachment #742845 - Flags: approval-mozilla-release?
Attachment #742845 - Flags: approval-mozilla-beta?
Attachment #742845 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

4 years ago
Blocks: 746142
(Assignee)

Comment 6

4 years ago
To give some context about why this feature is being restricted to Nightly and Aurora: we are not sure what are the attributes we want, Hixie specified different things from what we implemented and I now have a new set of values I would like us to support. We should only make the feature available in release when we will actually be willing to support it forever.
Comment on attachment 742845 [details] [diff] [review]
Patch

Its too late to get in in FX20 (release now) as we ~2weeks away from shipping Fx21.Approving on beta/aurora.

Please land on mozilla-beta asap so that this can get into our final beta.Do we need any QA testing here for verification?
Attachment #742845 - Flags: approval-mozilla-release?
Attachment #742845 - Flags: approval-mozilla-release-
Attachment #742845 - Flags: approval-mozilla-beta?
Attachment #742845 - Flags: approval-mozilla-beta+
Attachment #742845 - Flags: approval-mozilla-aurora?
Attachment #742845 - Flags: approval-mozilla-aurora+

Updated

4 years ago
tracking-firefox21: ? → +
https://hg.mozilla.org/mozilla-central/rev/68869162af7c
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox23: affected → fixed
Resolution: --- → FIXED
(Assignee)

Comment 9

4 years ago
(In reply to bhavana bajaj [:bajaj] from comment #7)
> Comment on attachment 742845 [details] [diff] [review]
> Patch
> 
> Its too late to get in in FX20 (release now) as we ~2weeks away from
> shipping Fx21.Approving on beta/aurora.

Thanks :) I didn't actually mean to ask approval-release. Second time that happened to me ;)

> Please land on mozilla-beta asap so that this can get into our final beta.Do
> we need any QA testing here for verification?

Yes, that would be great.
https://hg.mozilla.org/releases/mozilla-aurora/rev/a27b593bf117

This is going to need a beta-specific patch.
status-firefox22: affected → fixed
needsinfo on :mounir to help with comment# 10 as this needs to happen by Friday EOD PT to be ready for our final beta also can you explain what QA verification is needed here? Anything else in addition to making sure the pref is false by default ?
Flags: needinfo?(mounir)

Updated

4 years ago
Keywords: verifyme
(Assignee)

Comment 12

4 years ago
https://hg.mozilla.org/releases/mozilla-beta/rev/35a57e9f45a4

We don't have webidl on Beta so I didn't touch the idl to not make people go mad so the pref basically just disable the behaviour.

Regarding testing, QA could check that regular keyboard shows on (on Fx Android Beta) when focusing things in that file:
http://oldworld.fr/mozilla/inputmode.html

On Aurora/Nightly (Fx Android), some special keyboards should show up.
Flags: needinfo?(mounir)
(Assignee)

Updated

4 years ago
status-firefox21: affected → fixed

Updated

4 years ago
Keywords: qawanted
QA Contact: kbrosnan

Updated

4 years ago
Keywords: dev-doc-needed, site-compat
I've added this bug to the compatibility doc. Please correct the info if wrong.
https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_21
Keywords: dev-doc-needed → dev-doc-complete
Verified that using 21 beta 7 it is disabled

Verifed that using Aurora 22 and Nighty 23 it is enabled.

Is there any difference between titlecase and autocapitalized? Both resulted in text that only the first character was capitalized. Title case I would expect every word to be capitalized. I am unsure about autocapitalized behavior. The whatwg docs do not seem to provide guidance for these attributes http://www.whatwg.org/specs/web-apps/current-work/#attr-fe-inputmode
Status: RESOLVED → VERIFIED
status-firefox21: fixed → verified
status-firefox23: fixed → verified
status-firefox22: fixed → verified
Keywords: qawanted, verifyme
(Assignee)

Comment 15

4 years ago
Kevin, titlecase should uppercase every first character and autocapitalized should uppercase every first character of a sentence. The former should produces "Foo Bar. Foobar." and the later "Foo bar. Foobar.".
Depends on: 869584
(Assignee)

Comment 16

4 years ago
(In reply to Mounir Lamouri (:mounir) from comment #15)
> Kevin, titlecase should uppercase every first character and autocapitalized
> should uppercase every first character of a sentence. The former should
> produces "Foo Bar. Foobar." and the later "Foo bar. Foobar.".

Sounds good. Thanks :)
You need to log in before you can comment on or make changes to this bug.