857362 - Remove sendMessageToJava() events "FormHistory:Init:Return" and "Passwords:Init:Return" because they have no listeners

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chris Peterson [:cpeterson]]

D/GeckoEventDispatcher(32139): dispatchEvent: no listeners registered
  for event "FormHistory:Init:Return"
  D/GeckoEventDispatcher(32139): dispatchEvent: no listeners registered
  for event "Passwords:Init:Return"

Comment 1

[Mark Capella [:capella]]

Attachment: Patch (v1)

Small cleanup patch

Comment 2

[Chris Peterson [:cpeterson]]

Comment on attachment 739668 [details] [diff] [review]
Patch (v1)

Review of attachment 739668 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks!

::: mobile/android/chrome/content/browser.js
@@ +1303,1 @@
>          Services.obs.removeObserver(this, "Passwords:Init");

Please remove the blank line between storage.init() and removeObserver() like you did below for "FormHistory:Init".

Comment 3

[Mark Capella [:capella]]

push to try: https://tbpl.mozilla.org/?tree=Try&rev=d5af46f0d0aa

Comment 4

[Mark Capella [:capella]]

on to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/728db807e6a2

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/728db807e6a2