857526 - No rule to make target `trunk/Makefile', needed by `export' on platforms unsupported by webrtc

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Bug 750869 added something that disables webrtc on platforms that aren't supported. But it does so after AC_OUTPUT, so for the build system it's still enabled, while the Makefiles aren't generated from gyp. Thus the failure.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Check webrtc target arch right after checking target OS, instead of after AC_OUTPUT, which is too late

Comment 2

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d1e8c802365

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8d1e8c802365

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 732771 [details] [diff] [review]
Check webrtc target arch right after checking target OS, instead of after AC_OUTPUT, which is too late

[Approval Request Comment]
User impact if declined: Build failure on platforms not supported by webrtc.
Testing completed (on m-c, etc.): On m-c since a few days ago.
Risk to taking this patch (and alternatives if risky): Low. It only moves variables definitions in configure.in.
String or IDL/UUID changes made by this patch: None

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 732771 [details] [diff] [review]
Check webrtc target arch right after checking target OS, instead of after AC_OUTPUT, which is too late

Approving for downstream (local builds or otherwise).

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/dda95de72aec
https://hg.mozilla.org/releases/mozilla-beta/rev/f830a7473078