Closed
Bug 857526
Opened 11 years ago
Closed 11 years ago
No rule to make target `trunk/Makefile', needed by `export' on platforms unsupported by webrtc
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox20 wontfix, firefox21 fixed, firefox22 fixed, firefox23 fixed)
RESOLVED
FIXED
mozilla23
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
1.94 KB,
patch
|
ted
:
review+
akeybl
:
approval-mozilla-aurora+
akeybl
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Bug 750869 added something that disables webrtc on platforms that aren't supported. But it does so after AC_OUTPUT, so for the build system it's still enabled, while the Makefiles aren't generated from gyp. Thus the failure.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #732771 -
Flags: review?(ted)
Updated•11 years ago
|
Attachment #732771 -
Flags: review?(ted) → review+
Assignee | ||
Updated•11 years ago
|
Assignee | ||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d1e8c802365
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8d1e8c802365
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 732771 [details] [diff] [review] Check webrtc target arch right after checking target OS, instead of after AC_OUTPUT, which is too late [Approval Request Comment] User impact if declined: Build failure on platforms not supported by webrtc. Testing completed (on m-c, etc.): On m-c since a few days ago. Risk to taking this patch (and alternatives if risky): Low. It only moves variables definitions in configure.in. String or IDL/UUID changes made by this patch: None
Attachment #732771 -
Flags: approval-mozilla-beta?
Attachment #732771 -
Flags: approval-mozilla-aurora?
Comment 5•11 years ago
|
||
Comment on attachment 732771 [details] [diff] [review] Check webrtc target arch right after checking target OS, instead of after AC_OUTPUT, which is too late Approving for downstream (local builds or otherwise).
Attachment #732771 -
Flags: approval-mozilla-beta?
Attachment #732771 -
Flags: approval-mozilla-beta+
Attachment #732771 -
Flags: approval-mozilla-aurora?
Attachment #732771 -
Flags: approval-mozilla-aurora+
Comment 6•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/dda95de72aec https://hg.mozilla.org/releases/mozilla-beta/rev/f830a7473078
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•