Closed Bug 857557 Opened 7 years ago Closed 7 years ago

Avoid autoconf.mk being modified for new other-platform-specific variables

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla23

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

A common pattern that triggers autoconf.mk to be updated, thus making the build essentially a clobber is when we add a platform-specific variable. The variable usually has an empty value on other platforms, but the mere fact of adding its empty value in autoconf.mk makes the build a clobber. But besides $(origin), there's not much difference between a variable defined to nothing and a variable not defined at all in make.
Comment on attachment 732793 [details] [diff] [review]
Avoid autoconf.mk being modified for new other-platform-specific variables

Review of attachment 732793 [details] [diff] [review]:
-----------------------------------------------------------------

Please add a code comment somewhere saying that filtering empty variables results in less invalidation of build dependencies.
Attachment #732793 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/43ec10ce6056
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.