857589 - Windows plugin dir service provider shouldn't warn on missing plugin registry key

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Georg Fritzsche [:gfritzsche]]

Attachment: Bail out without warning on missing reg key

nsPluginDirServiceProvider triggers a warning if it can't access the reg-key "Software\MozillaPlugins" here:
http://hg.mozilla.org/mozilla-central/annotate/3a5929ebc886/dom/plugins/base/nsPluginDirServiceProvider.cpp#l378

AFAIK this reg-key not existing is perfectly fine and we don't need to spam e.g. try logs with it (at least WinXP try slaves don't have any reg keys for plugins set).

Comment 1

[Georg Fritzsche [:gfritzsche]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e59593a4baa1

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e59593a4baa1

Comment 3

[Mihai Morar, (:MihaiMorar)]

(In reply to Georg Fritzsche [:gfritzsche] from comment #1)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/e59593a4baa1

How can QA verify this fix?

Comment 4

[Georg Fritzsche [:gfritzsche]]

It's just a cosmetic change of a warning not being shown in logs, so i don't think this needs verification.