857617 - Clean up nsEditor::InsertTextImpl

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

I had this patch lying around from something else, so I figured I may as well submit it.

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Patch

3 files changed, 87 insertions(+), 125 deletions(-)

Passes editor tests locally.  This depends on bug 857102 (and motivated it).

https://tbpl.mozilla.org/?tree=Try&rev=d00358ddc5c2

Comment 2

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e03a9a31e9c4

Comment 3

[(no longer active)]

Backed out because of build bustage:

https://hg.mozilla.org/integration/mozilla-inbound/rev/b5452903fc2f
https://tbpl.mozilla.org/php/getParsedLog.php?id=21407652&tree=Mozilla-Inbound#error0

Seems like this depends on another patch?

Comment 4

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

(In reply to :Aryeh Gregor from comment #1)
> This depends on bug 857102 (and motivated it).

I'll land it together with that when I get a chance.

Comment 5

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b0dd6a562281

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b0dd6a562281