857649 - Tabs are drawn wrong for win7 taskbar previews

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[Wesley Johnston (:wesj)]

Attachment: Screenshot

Tabs only seem to be highlighted in their center when I hover the tab in our win7 taskbar previews mode. They also seem to be missing the slight separator between them on my system.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: about:support

about:support in case its helpful

Comment 2

[Frank Yan (:fryn)]

Do you only see this with browser.taskbar.previews.enable = true?

Comment 3

[Matthew N. [:MattN]]

Thanks for the report.  I would guess this is related to the pseudo-elements and/or -moz-windows-compositor/-moz-windows-glass differences for the thumbnails.

(In reply to Wesley Johnston (:wesj) from comment #0)
> They also seem to be missing the slight separator between them on my system.

This is bug 857626.

Comment 4

[Matthew N. [:MattN]]

(In reply to Wesley Johnston (:wesj) from comment #0)
> Tabs only seem to be highlighted in their center when I hover the tab in our
> win7 taskbar previews mode.

I don't see an addressbar in your screenshot, is this also only happening with tab previews?

(In reply to Wesley Johnston (:wesj) from comment #0)
> They also seem to be missing the slight separator between them on my system.

I see separators in your screenshot.  Do they only appear with the previews?

Comment 5

[Wesley Johnston (:wesj)]

(In reply to Frank Yan (:fryn) from comment #2)
> Do you only see this with browser.taskbar.previews.enable = true?

Yes

(In reply to Matthew N. [:MattN] from comment #4)
> I don't see an addressbar in your screenshot, is this also only happening
> with tab previews?

Yes. 

> I see separators in your screenshot.  Do they only appear with the previews?
Oh you're right. I updated between the screenshot and when I filed.

Comment 6

[Matthew N. [:MattN]]

> (In reply to Matthew N. [:MattN] from comment #4)
> > I don't see an addressbar in your screenshot, is this also only happening
> > with tab previews?
> 
> Yes. 

I filed bug 863635 for this.  It may end up having the same solution of fixing this one.

Comment 7

[Matthew N. [:MattN]]

Assigning M7 for now since bug 863635 is already in the release channel and this only happens in a non-default config.

Comment 8

[Matthew N. [:MattN]]

Bug 863635 is now fixed so tabs are not as ugly and the location bar is visible. I suspect the remaining work is related to the interaction between tab previews, tabbrowser.xml, and our tab CSS. I'll poke at this a bit.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Removing the items from M7 that do not block us from landing on m-c.

Comment 10

[Justin Dolske [:Dolske]]

Sounds like this was mostly fixed, but I'm not sure how bad "not as ugly" is offhand.

Comment 11

[Mike Conley (:mconley) (:⚙️)]

I just tested this on Windows 7, and I no longer see the issue that this bug was originally opened for. Marking RESOLVED WORKSFORME.

Comment 12

[Matthew N. [:MattN]]

The tab which was selected before hovering the preview is still partially styled when another preview is hovered and it looks bad with the separators overlapping the start/end.

Comment 13

[Matthew N. [:MattN]]

Attachment: Updated screenshot

Updated screenshot after the fix in bug 863635 (see comment 8).

The original selected tab, its separator and the fog on the window controls still have issues.