857656 - www.RCFlightDeck.com - Version 20 breaks what works in all previous versions with SlideDeck

Status: RESOLVED INVALID

(Web Compatibility :: Site Reports, defect)

Description

[Michael Kranitz]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:18.0) Gecko/20100101 Firefox/18.0
Build ID: 20130116073211

Steps to reproduce:

Visit http://www.rcflightdeck.com in Version 19 or lower.  Notice the slide deck atop the page.  Now visit in Version 20.  Completely broken.  Very obvious.  Confirmed on Windows XP, Windows 7, Mac



Expected results:

The slide deck should display as it does in all other versions

Comment 1

[Michael Kranitz]

SlideDeck is a very popular JQuery slider.

Comment 2

[Alice0775 White]

It works if UA spoofed as follows
general.useragent.override = Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/20100101 Firefox/19.0

So, this is a site Bug. 

And this is a Tech Evangelism Bug.

Comment 3

[Alice0775 White]

Could you contact the www.RCFlightDeck.com support and give the link of this bug, so they could fix their browser detection JS code.

Comment 4

[Michael Kranitz]

So do I understand you correctly that I have to spoof an earlier version of FF to make this work?  How is that a site bug?

Comment 5

[Michael Kranitz]

I would appreciate guidance on how to properly implement this inasmuch as I simply declare html 5 doctype at the top of the pages and do not try to detect browsers.  I'm not sure how to do this.

Comment 6

[Michael Kranitz]

Lastly, i notice that spoofing the UA in my code is not recommended by your development community.

https://developer.mozilla.org/en-US/docs/DOM/window.navigator.userAgent

I'm lost.

Comment 7

[Alice0775 White]

The offending code is in js/slidedeck.jquery.js

The js detect kind of browser and version by using UA string.

var UA=navigator.userAgent.toLowerCase();this.browser={ ...

This way is wrong and not recommended as described in https://developer.mozilla.org/en-US/docs/DOM/window.navigator.userAgent.

You should modify js/slidedeck.jquery.js to use object based feature detection

Comment 8

[Michael Kranitz]

is it difficult to modify?  I'm not certain I could do this!

Comment 9

[Alice0775 White]

(In reply to Michael Kranitz from comment #8)
> is it difficult to modify?  I'm not certain I could do this!

I think better place to discussion is http://forums.mozillazine.org/viewforum.php?f=25
(Bugzilla is not a support forum.)

Comment 10

[Karl Dubost💡 :karlcow]

There is no slidedeck at the top of the page. The design must have changed.
If I have missed it. Please reopen.