Closed Bug 857656 Opened 9 years ago Closed 8 years ago

www.RCFlightDeck.com - Version 20 breaks what works in all previous versions with SlideDeck

Categories

(Web Compatibility :: Desktop, defect)

defect
Not set
normal

Tracking

(firefox19 unaffected, firefox20 affected, firefox21 affected, firefox22 affected, firefox23 affected)

RESOLVED INVALID
Tracking Status
firefox19 --- unaffected
firefox20 --- affected
firefox21 --- affected
firefox22 --- affected
firefox23 --- affected

People

(Reporter: michael, Unassigned)

References

()

Details

(Keywords: regression)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:18.0) Gecko/20100101 Firefox/18.0
Build ID: 20130116073211

Steps to reproduce:

Visit http://www.rcflightdeck.com in Version 19 or lower.  Notice the slide deck atop the page.  Now visit in Version 20.  Completely broken.  Very obvious.  Confirmed on Windows XP, Windows 7, Mac



Expected results:

The slide deck should display as it does in all other versions
Severity: normal → major
OS: Mac OS X → All
Hardware: x86 → All
Version: 18 Branch → 20 Branch
SlideDeck is a very popular JQuery slider.
It works if UA spoofed as follows
general.useragent.override = Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/20100101 Firefox/19.0

So, this is a site Bug. 

And this is a Tech Evangelism Bug.
Severity: major → normal
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
Assignee: nobody → english-us
Component: Untriaged → English US
Product: Firefox → Tech Evangelism
Version: 20 Branch → unspecified
Could you contact the www.RCFlightDeck.com support and give the link of this bug, so they could fix their browser detection JS code.
Summary: Version 20 breaks what works in all previous versions with SlideDeck → www.RCFlightDeck.com - Version 20 breaks what works in all previous versions with SlideDeck
So do I understand you correctly that I have to spoof an earlier version of FF to make this work?  How is that a site bug?
I would appreciate guidance on how to properly implement this inasmuch as I simply declare html 5 doctype at the top of the pages and do not try to detect browsers.  I'm not sure how to do this.
Lastly, i notice that spoofing the UA in my code is not recommended by your development community.

https://developer.mozilla.org/en-US/docs/DOM/window.navigator.userAgent

I'm lost.
The offending code is in js/slidedeck.jquery.js

The js detect kind of browser and version by using UA string.

var UA=navigator.userAgent.toLowerCase();this.browser={ ...

This way is wrong and not recommended as described in https://developer.mozilla.org/en-US/docs/DOM/window.navigator.userAgent.

You should modify js/slidedeck.jquery.js to use object based feature detection
is it difficult to modify?  I'm not certain I could do this!
(In reply to Michael Kranitz from comment #8)
> is it difficult to modify?  I'm not certain I could do this!

I think better place to discussion is http://forums.mozillazine.org/viewforum.php?f=25
(Bugzilla is not a support forum.)
There is no slidedeck at the top of the page. The design must have changed.
If I have missed it. Please reopen.
Assignee: english-us → nobody
Status: NEW → RESOLVED
Closed: 8 years ago
Component: English US → Desktop
Resolution: --- → INVALID
Product: Tech Evangelism → Web Compatibility
You need to log in before you can comment on or make changes to this bug.