857669 - Remove unused traversal function

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Bug 855804 removed this

Comment 1

[Daniel Holbert [:dholbert]]

Could you add back the FAIL_ON_WARNINGS as part of this bug? (the one that you'd removed
due to this unused-function triggering a warning, in https://hg.mozilla.org/integration/mozilla-inbound/rev/c4cec4613cac )

Comment 2

[Mounir Lamouri (:mounir)]

Comment on attachment 732916 [details] [diff] [review]
Patch

Review of attachment 732916 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with dholbert comment applied.

Comment 3

[Daniel Holbert [:dholbert]]

Disregard comment 1; I don't think this needs to restore the MSVC-exempted FAIL_ON_WARNINGS annotation anymore, because I'll be fixing all remaining MSVC warnings and adding a no-exemptions FAIL_ON_WARNINGS annotation for this directory over in bug 860913.

So as far as I'm concerned, this patch can land as-is.  (mounir, presumably that's fine with you as well?)

Comment 4

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #3)
> So as far as I'm concerned, this patch can land as-is.  (mounir, presumably
> that's fine with you as well?)

(given the r+ on patch 3 in bug 860913, I think it's safe to assume that Mounir is also fine with this landing as-is. So: khuey, you're clear to land (and you can ignore comment 1.))

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e152843b366d