857715 - testing/xpcshell/head.js should use 'uneval' to splice values into computed JS source

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Jim Blandy :jimb]

Attachment: In testing/xpcshell/head.js, use 'uneval' to quote values passed to the child process.

In testing/xpcshell/head.js, do_load_child_test_harness does various just-good-enough kludges to pass some string-valued parameters to the child process. However, the built-in 'uneval' function does exactly the sort of quoting that's needed here, and handles arrays automatically. do_load_child_test_harness should use 'uneval'.

Comment 1

[Jim Blandy :jimb]

https://tbpl.mozilla.org/?tree=Try&rev=8415a27cab29

Comment 2

[Jim Blandy :jimb]

Comment on attachment 732966 [details] [diff] [review]
In testing/xpcshell/head.js, use 'uneval' to quote values passed to the child process.

Try run looked good.

Comment 3

[Benjamin Smedberg]

Comment on attachment 732966 [details] [diff] [review]
In testing/xpcshell/head.js, use 'uneval' to quote values passed to the child process.

I'm going to forward this on to Ted as owner of the testing infrastructure, and he will probably forward it along to somebody else. Hot potato!

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 732966 [details] [diff] [review]
In testing/xpcshell/head.js, use 'uneval' to quote values passed to the child process.

Review of attachment 732966 [details] [diff] [review]:
-----------------------------------------------------------------

That's a much cleverer solution.

Comment 5

[Jim Blandy :jimb]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9854f6db382b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9854f6db382b