Closed Bug 857715 Opened 8 years ago Closed 8 years ago

testing/xpcshell/head.js should use 'uneval' to splice values into computed JS source

Categories

(Testing :: XPCShell Harness, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla23

People

(Reporter: jimb, Assigned: jimb)

Details

Attachments

(1 file)

In testing/xpcshell/head.js, do_load_child_test_harness does various just-good-enough kludges to pass some string-valued parameters to the child process. However, the built-in 'uneval' function does exactly the sort of quoting that's needed here, and handles arrays automatically. do_load_child_test_harness should use 'uneval'.
Comment on attachment 732966 [details] [diff] [review]
In testing/xpcshell/head.js, use 'uneval' to quote values passed to the child process.

Try run looked good.
Attachment #732966 - Flags: review?(benjamin)
Comment on attachment 732966 [details] [diff] [review]
In testing/xpcshell/head.js, use 'uneval' to quote values passed to the child process.

I'm going to forward this on to Ted as owner of the testing infrastructure, and he will probably forward it along to somebody else. Hot potato!
Attachment #732966 - Flags: review?(benjamin) → review?(ted)
Comment on attachment 732966 [details] [diff] [review]
In testing/xpcshell/head.js, use 'uneval' to quote values passed to the child process.

Review of attachment 732966 [details] [diff] [review]:
-----------------------------------------------------------------

That's a much cleverer solution.
Attachment #732966 - Flags: review?(ted) → review+
Assignee: nobody → jimb
Component: IPC → XPCShell Harness
Product: Core → Testing
https://hg.mozilla.org/integration/mozilla-inbound/rev/9854f6db382b
Status: NEW → ASSIGNED
Flags: in-testsuite-
Target Milestone: --- → mozilla23
https://hg.mozilla.org/mozilla-central/rev/9854f6db382b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.