857797 - Disable Gamepad API for Firefox 22

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(not currently active) Ted Mielczarek]

Since bug 851547 didn't make the cut, we'll just disable the Gamepad API in configure. I'll post a patch in a little bit.

Comment 1

[Alex Keybl [:akeybl]]

Please make sure to change the target milestone for bug 604039 once this lands, for sanity.

Comment 2

[Alex Keybl [:akeybl]]

Before release noting bug 604039 for Firefox 22, can you confirm that we'll be performing this disable at the end of the Aurora cycle?

Comment 3

[(not currently active) Ted Mielczarek]

Yes, I'll get a simple patch up here today, should be a 1-liner. We can land it whenever you want during the Aurora cycle.

Comment 4

[(not currently active) Ted Mielczarek]

Attachment: Disable Gamepad API for Firefox 22

Pretty trivial patch.

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 736053 [details] [diff] [review]
Disable Gamepad API for Firefox 22

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 

User impact if declined: Would ship an unfinished Web API

Testing completed (on m-c, etc.): Trivial patch, builds fine locally.

Risk to taking this patch (and alternatives if risky): Minimal, any bustage should show up as immediate build bustage.

String or IDL/UUID changes made by this patch: None

Comment 6

[Alex Keybl [:akeybl]]

Leaving this in the queue for now since it sounds like we'd like people to test on Aurora. Also nominating for tracking FF23, since it's not clear whether we'll ship the finished API in that version.

Comment 7

[(not currently active) Ted Mielczarek]

I'm hoping to be able to land bug 851547 in time for FF23, so we can simply pref it off instead of having to disable it at build time, but that has a dependency that it's waiting on.

I would like to make this available on Aurora for as long as is reasonable, but feel free to land this (or ask me to land it) whenever you need to.

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Tracking for 23, leaving the disabling patch nominated for now, it can be landed later in the Aurora cycle.

Comment 9

[Alex Keybl [:akeybl]]

Comment on attachment 736053 [details] [diff] [review]
Disable Gamepad API for Firefox 22

We're close to the end of the cycle. Approving this disable for Aurora 22.

Comment 10

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4d2ac1883ce8

Comment 11

[(not currently active) Ted Mielczarek]

bug 851547 landed in time for Firefox 24, but it didn't make Firefox 23, so we should land the disabling patch here for 23 (which I guess is beta as of today). I'm on vacation the rest of this week, but it's a simple patch if someone wants to land it. Otherwise I can do it when I'm back next week.

Comment 12

[(not currently active) Ted Mielczarek]

Thanks, I should have just requested the approval.

Comment 13

[(not currently active) Ted Mielczarek]

Fixed for 23:
https://hg.mozilla.org/releases/mozilla-beta/rev/480f6c51f45a

I'm marking this FIXED because 24 has the API behind a pref, so we should no longer need to disable it this way.

Comment 14

[Cornel Ionce [:noni] [Hubs QA]]

Verified as fixed on FF 23 beta 9 (build ID: 20130725195523)

Used http://people.mozilla.com/~tmielczarek/combat/ page for testing.
Also, the dom.gamepad.enabled pref is not shown.