Closed Bug 857801 Opened 7 years ago Closed 7 years ago

prevent glowing Download Notification Effect of Toolbar Button with Panel opened

Categories

(Firefox :: Downloads Panel, defect)

Product:
Firefox
Component:
Downloads Panel
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 23

People

(Reporter: xtc4uall, Assigned: Optimizer)

Details

Attachments

(1 file, 1 obsolete file)

fix to land
1.18 KB, patch
Optimizer
: review+
Details | Diff | Splinter Review 
* download a File
* open the Panel and keep it open until Download finishes

Actual:
glowing Effect executed when Download is finished

Expected:
Since I can follow the File's Download Progress in the Panel the Notification Effect of the Button in Addition when the Download is finished is unnecessary
Attached patch fix (obsolete) — — Splinter Review 
Just checking if the panel is open before any visual indicator starting.
Assignee: nobody → scrapmachines
Status: NEW → ASSIGNED
Attachment #744077 - Flags: review?(mak77)
Attachment #744077 - Flags: review?(mak77) → review?(mconley)
Comment on attachment 744077 [details] [diff] [review]
fix

This looks like the right move. Assuming all tests under browser/components/downloads/test pass, r=me.
Attachment #744077 - Flags: review?(mconley) → review+
Attached patch fix to land — — Splinter Review 
r=mconley

All tests passed.
Attachment #744077 - Attachment is obsolete: true
Attachment #745264 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e3e7f9657fcd
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
You need to log in before you can comment on or make changes to this bug.