Closed
Bug 857801
Opened 12 years ago
Closed 12 years ago
prevent glowing Download Notification Effect of Toolbar Button with Panel opened
Categories
(Firefox :: Downloads Panel, defect)
Firefox
Downloads Panel
Tracking
()
RESOLVED
FIXED
Firefox 23
People
(Reporter: xtc4uall, Assigned: Optimizer)
Details
Attachments
(1 file, 1 obsolete file)
|
1.18 KB,
patch
|
Optimizer
:
review+
|
Details | Diff | Splinter Review |
* download a File
* open the Panel and keep it open until Download finishes
Actual:
glowing Effect executed when Download is finished
Expected:
Since I can follow the File's Download Progress in the Panel the Notification Effect of the Button in Addition when the Download is finished is unnecessary
|
Assignee | |
Comment 1•12 years ago
|
||
Just checking if the panel is open before any visual indicator starting.
|
|
Assignee | |
Updated•12 years ago
|
Attachment #744077 -
Flags: review?(mak77) → review?(mconley)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 744077 [details] [diff] [review]
fix
This looks like the right move. Assuming all tests under browser/components/downloads/test pass, r=me.
Attachment #744077 -
Flags: review?(mconley) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
r=mconley
All tests passed.
Attachment #744077 -
Attachment is obsolete: true
Attachment #745264 -
Flags: review+
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 4•12 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
You need to log in
before you can comment on or make changes to this bug.
Description
•