prevent glowing Download Notification Effect of Toolbar Button with Panel opened
RESOLVED
FIXED
in Firefox 23
Status
()
People
(Reporter: xtc4uall, Assigned: Optimizer)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment, 1 obsolete attachment)
|
1.18 KB,
patch
|
Optimizer
:
review+
|
Details | Diff | Splinter Review |
* download a File * open the Panel and keep it open until Download finishes Actual: glowing Effect executed when Download is finished Expected: Since I can follow the File's Download Progress in the Panel the Notification Effect of the Button in Addition when the Download is finished is unnecessary
|
(Assignee) | |
Comment 1•6 years ago
|
||
Created attachment 744077 [details] [diff] [review] fix Just checking if the panel is open before any visual indicator starting.
|
|
(Assignee) | |
Updated•6 years ago
|
||
Attachment #744077 -
Flags: review?(mak77) → review?(mconley)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 744077 [details] [diff] [review] fix This looks like the right move. Assuming all tests under browser/components/downloads/test pass, r=me.
Attachment #744077 -
Flags: review?(mconley) → review+
|
|
(Assignee) | |
Comment 3•6 years ago
|
||
Created attachment 745264 [details] [diff] [review] fix to land r=mconley All tests passed.
Attachment #744077 -
Attachment is obsolete: true
Attachment #745264 -
Flags: review+
|
|
(Assignee) | |
Updated•6 years ago
|
||
Keywords: checkin-needed
|
||
Comment 4•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3e7f9657fcd
Keywords: checkin-needed
|
|
||
Comment 5•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e3e7f9657fcd
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
You need to log in
before you can comment on or make changes to this bug.
Description
•