857823 - Update form assistant to handle new skb functionality

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Input, defect)

Description

[Jim Mathies [:jimm]]

This will also give us the chance to rip some of the code in this we are not using.

Comment 1

[Jim Mathies [:jimm]]

Attachment: wip

Comment 2

[Jim Mathies [:jimm]]

Attachment: formassist patch v.1

This patch builds on top of the other work to shift forms around when they get obscured by the soft keyboard. 90% if removing obsolete code from FormHelper.js. The only thing it does now is manage select and auto-complete popups.

I'll post a rollup of all the work in the skb bug below this if you're curious.

Comment 3

[Jim Mathies [:jimm]]

* "90% of this is removing"

Comment 4

[Frank Yan (:fryn)]

Comment on attachment 733369 [details] [diff] [review]
formassist patch v.1

Review of attachment 733369 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3d0b269794a9