mozharness nosetests broken on windows again

RESOLVED FIXED

Status

Release Engineering
Mozharness
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: aki, Assigned: aki)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mozharness])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
For most of the errors, it looked like an issue with the raw log not being closed before starting the next test, resulting in the next test being unable to remove the file.
(Assignee)

Comment 1

5 years ago
Created attachment 735501 [details] [diff] [review]
get windows nosetests to pass

I was able to pass ./unit.sh (nosetests) with this patch applied on w64-ix-slave22 with both mercurial==1.7.3 and mercurial==2.5.3.
Attachment #735501 - Flags: review?(rail)
Comment on attachment 735501 [details] [diff] [review]
get windows nosetests to pass

Review of attachment 735501 [details] [diff] [review]:
-----------------------------------------------------------------

::: test/test_base_script.py
@@ +393,5 @@
>          self.s = script.BaseScript(initial_config_file='test/test.json')
>  
> +    def tearDown(self):
> +        if hasattr(self, 's') and isinstance(self.s, object):
> +            del(self.s)

Can you comment why you need to delete this object?
Attachment #735501 - Flags: review?(rail) → review+
(Assignee)

Comment 3

5 years ago
Comment on attachment 735501 [details] [diff] [review]
get windows nosetests to pass

http://hg.mozilla.org/build/mozharness/rev/b1dbc0f56ff8
with comments.
Attachment #735501 - Flags: checked-in+
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering

Updated

4 years ago
Component: General Automation → Mozharness
You need to log in before you can comment on or make changes to this bug.