857944 - IMEI check. It is necessary to press "SEND" key after dial the code *#06#

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[Beatriz Rodríguez [:brg]]

To check the IMEI number, it is necessary to press "SEND" key after dial the code *#06#     

- Steps to Reproduce:
Open Dialer
Dial *#06#

- Actual Result:
Nothing happend until user press "SEND" key        

- Expected Result (correct behaviour wished):
It should show automatically the IMEI when dialing the *#06#

Buildid "20130321070205", device: ikura

Comment 1

[Etienne Segonzac (:etienne)]

Is this needed _only_ for the IMEI code?

Comment 2

[Germán Toro del Valle (:gtorodelvalle)]

Adding the need-info request for Beatriz to attend Etienne's question ;-)

On the other hand, it seems to be something related to the Ikura device. At least in the Unagi it does not reproduce :-( Sadly I do not have any Ikura at hand to test it :-(

Comment 3

[Beatriz Rodríguez [:brg]]

(In reply to Etienne Segonzac (:etienne) from comment #1)
> Is this needed _only_ for the IMEI code?
Yes, it is _only_ needed for IMEI code

(In reply to gtorodelvalle from comment #2)
> On the other hand, it seems to be something related to the Ikura device. At
> least in the Unagi it does not reproduce :-( Sadly I do not have any Ikura
> at hand to test it :-(
Tested right now with Unagi device (unagi-ICS.user.manifest.V1-train.Rel0.4.Sprint8.B-81.Gecko-303a259.Gaia-d06432a) and I can reproduce the issue easily :-(

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

(In reply to Etienne Segonzac (:etienne) from comment #1)
> Is this needed _only_ for the IMEI code?

Yes, please! In other case, that would be a security issue. Some vendors use an MMI code to do a factory reset, for example. The user must confirm the send of an MMI code through the dialer send button.

(In reply to gtorodelvalle from comment #2)
> Adding the need-info request for Beatriz to attend Etienne's question ;-)
> 
> On the other hand, it seems to be something related to the Ikura device. At
> least in the Unagi it does not reproduce :-( Sadly I do not have any Ikura
> at hand to test it :-(

This is easily reproducible in any Firefox OS device. By design we don't send any MMI code until we hit the send key from the dial pad.

Having this kind of certification requirement is really unfortunate... :\

I'll take this.

Comment 5

[Antonio Manuel Amaya Calvo (:amac)]

As Fernando said, this has to be only for the IMEI. And I would prefer for it to still need to press the dial key if the number is passed from an activity.

Comment 6

[Germán Toro del Valle (:gtorodelvalle)]

Are we talking about the same "Send" button and "dialing" concepts? :-) I mean, I understood that when Beatriz said "Dial *#06#", she was referring to typing *#06# and pressing the "Call" (green) button. Regarding the "Send" button, I thought she was referring to the one shown on the upper-right corner of the USSD/MMI screen. Yeah, I am weird... :-ppp

Comment 7

[Germán Toro del Valle (:gtorodelvalle)]

I guess Beatriz may want to say something regarding the "Yes please" by Fernando in comment 4 as well as to Antonio in comment 5 ;-)

Comment 8

[Beatriz Rodríguez [:brg]]

(In reply to Antonio Manuel Amaya Calvo from comment #5)
> As Fernando said, this has to be only for the IMEI. And I would prefer for
> it to still need to press the dial key if the number is passed from an
> activity.
This is blocking the certification process. Android and IOS devices do not need to press the "dial"/"green" button in the dialer.

(In reply to gtorodelvalle from comment #6)
> Are we talking about the same "Send" button and "dialing" concepts? :-) I
> mean, I understood that when Beatriz said "Dial *#06#", she was referring to
> typing *#06# and pressing the "Call" (green) button. 
I am talking about the green key in the dialer keypad, sorry for saying "SEND" (my fault)

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8996

Pointer to Github pull-request

Comment 10

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 733431 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8996

Etienne, here it goes my naive attempt to solve this issue. Could you give me your feedback while I write a few tests for it, please?

Comment 11

[Fernando Jiménez Moreno [:ferjm]]

(In reply to Antonio Manuel Amaya Calvo from comment #5)
> As Fernando said, this has to be only for the IMEI. And I would prefer for
> it to still need to press the dial key if the number is passed from an
> activity.

If I am not wrong, with the attached patch, a 'dial' activity request containing a "*#06#" will still require the user to hit the dial key to be completed as an actual MMI request.

http://mxr.mozilla.org/gaia/source/apps/communications/dialer/js/dialer.js#38

Comment 12

[Antonio Manuel Amaya Calvo (:amac)]

(In reply to Beatriz Rodríguez [:brg] from comment #8)
> (In reply to Antonio Manuel Amaya Calvo from comment #5)
> > As Fernando said, this has to be only for the IMEI. And I would prefer for
> > it to still need to press the dial key if the number is passed from an
> > activity.
> This is blocking the certification process. Android and IOS devices do not
> need to press the "dial"/"green" button in the dialer.

For the IMEI I agree, since it's mostly harmless. For all the other cases, it should still require pressing the dial button. Android had a vulnerability not too long ago related with this, check [1] for example. That's why I would prefer for the send button to be required still when the number is passed from an activity (dunno if the certification test involves that or not).

[1] http://labs.bitdefender.com/2012/10/ussd-exploit-can-lock-all-android-phone-sim-cards/

Comment 13

[David Palomino [:dpalomino]]

Changing prio to P1, as this is a certification blocker.

Comment 14

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 733431 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8996

I've just added a test for this modification.

Etienne, the conditions added in dialer.js are needed to be able to run the test. I also renamed mock_call_handler.js to mock_on_call.js which is more appropriate.

Comment 15

[Etienne Segonzac (:etienne)]

Comment on attachment 733431 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8996

Quick comment on github, should be easy to fix :)

Comment 16

[Juan Perez-Bedmar [:juanpbf]]

Adding some colleagues in CC

Comment 17

[Fernando Jiménez Moreno [:ferjm]]

Thanks Etienne!

https://github.com/mozilla-b2g/gaia/commit/6f68e8960abe2926c9da8718203b463d1a251b27

Comment 18

[Jeni]

Verfied fixed on Master Build

Updated to Unagi Build ID: 20130410065939
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/mozilla-central/rev/ee5ca214e87c
Gaia: f6587418cc5fd8dfe885539ae1a798473890c7f5

Verified Not fixed on 

Unagi Build ID: 20130410070204
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/935ff9a97f7b
Gaia: aff876b051c51d091cecf322b90c4f0093281b5e

and on 

Unagi Build ID: 20130410070209
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/423f7851bdb5
Gaia: c614b3f3c956dc1e1adf93cf4cf41511ce75de80

Comment 19

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: f2133bee28657b8ec435d14d820a3684be491a10

Comment 20

[John Ford [:jhford] CET/CEST Berlin Time]

the needsinfo was because this does not uplift cleanly to v1.0.1

Comment 21

[Fernando Jiménez Moreno [:ferjm]]

v1.0.1: https://github.com/mozilla-b2g/gaia/commit/4fe35d48c37addce8fae56b069905026f7d8d083

Comment 22

[isabelrios]

This is working as expected on Ikura device. 
Build id: 20130421003941

Comment 23

[John Hammink]

Tested with AT4 team in Chile.  Working correctly on both my 4/26 and 5/13 partner builds.