857948 - [FHR] jquery.plot.js plugin has hardcoded month names

Status: RESOLVED FIXED

(Firefox Health Report Graveyard :: Web: Health Report, defect)

Description

[Pascal Chevrel:pascalc]

https://github.com/mozilla/fhr-jelly/blame/master/js/jquery.flot.js#L2550

Maybe Replacing the month names by month numbers would work:
monthNames = ["01", "02", "03", "04", "05", "06", "07", "08", "09", "10", "11", "12"];

then displaying dates as:
22/04

instead of 
Apr 22

Comment 1

[Laura Thomson :laura]

Pascal: wouldn't we then need to localize the date formats anyway? Although I suppose we could go all ISO on it and make the dates YYYY-MM-DD?

Comment 2

[Pascal Chevrel:pascalc]

whatever doesn't expose English words is fine for me :)

Comment 3

[Pascal Chevrel:pascalc]

we have now a date.lang file in each locales folder, it is converted from properties to .lang directly from Firefox source code. If you need them in another format for js, I can generate json files for example. That should cover most of our needs for dates in the graphs.

Comment 4

[Schalk Neethling [:espressive]]

I am wondering can we have the months in a properties style file like so:

short_month_names = Jan,Feb,Mar,Apr....
full_month_names= January,February,March,April...

The current format below does not play well with webl10n.js:

;Jan
Dwe me acel

;Feb
Dwe me aryo

;Mar
Dwe me adek

;Apr
Dwe me angwen

Perhaps we can make it work but, it is not ideal.

Comment 5

[Schalk Neethling [:espressive]]

Pascal, thoughts on the above?

Comment 6

[Pascal Chevrel:pascalc]

sure, we could just copy the properties file from Firefox source code into out repositories. I can do that on Friday.

Comment 7

[Schalk Neethling [:espressive]]

(In reply to Pascal Chevrel:pascalc from comment #6)
> sure, we could just copy the properties file from Firefox source code into
> out repositories. I can do that on Friday.

Much appreciated Pascal

Comment 8

[Schalk Neethling [:espressive]]

(In reply to Pascal Chevrel:pascalc from comment #6)
> sure, we could just copy the properties file from Firefox source code into
> out repositories. I can do that on Friday.

Just ping this bug once it is done. Thanks again!

Comment 9

[Pascal Chevrel:pascalc]

Files copied in r115824

Comment 11

[Francesco Lodolo [:flod]]

Hi, any update on this?

For what I understand of flot, it should be enough to add a localized monthNames array here instead of messing with the library code
https://github.com/mozilla/fhr-jelly/blob/master/js/fhr.js#L101

Comment 12

[Bogomil Shopov[:Bogomil]]

So we have localized data into the folder, the only thing someone must do is to load the months into the script.

Comment 13

[Schalk Neethling [:espressive]]

Yes, it is pretty simple. This is on my todo list for this week.

Comment 14

[Pascal Chevrel:pascalc]

Any news on this one? Thanks

Comment 15

[Schalk Neethling [:espressive]]

(In reply to Pascal Chevrel:pascalc from comment #14)
> Any news on this one? Thanks

Got distracted by some other projects and other PRs on FHR, will be back on this one next.