Closed
Bug 858029
Opened 11 years ago
Closed 11 years ago
Not possible to send to an international number from the SMS app via direct input
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 856085
People
(Reporter: janjongboom, Unassigned)
Details
Attachments
(1 obsolete file)
Go into the SMS app, press 'New', and start typing an international number like '+31'. Errors will flood the console because we don't escape literal text before putting it in a regexp. Thus creating incorrect regular expressions.
|
Reporter | |
Comment 1•11 years ago
|
||
Escape literal text first before making it into a regex.
Attachment #733288 -
Flags: review?(fbsc)
|
|
Reporter | |
Comment 2•11 years ago
|
||
Updated the PR + added tests.
|
||
Comment 3•11 years ago
|
||
Hi, Thanks for this bug. Since we're redoing the contacts matching in Bug 856085, we'll integrate your tests in it and we'll take care of not choking at this. Closing as duplicate then.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
|
|
||
Updated•11 years ago
|
Attachment #733288 -
Attachment is obsolete: true
Attachment #733288 -
Flags: review?(fbsc)
You need to log in
before you can comment on or make changes to this bug.
Description
•