Closed Bug 858044 Opened 11 years ago Closed 10 years ago

Make addon startup code more resilient by using nsISessionStore.restored

Categories

(Add-on SDK Graveyard :: General, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1042239

People

(Reporter: ochameau, Unassigned)

References

Details

Attachments

(1 file)

Bug 857602 is going to implement nsISessionStore.restored. A new flag to know if sessionstore-windows-restored event has already been fired or not -or- just know if the session has already been restored or not.

We should start using it in order to safely wait for sessionstore-windows-restored or not. We used to had weak assumptions based on addon startup reason, but it broke when we fixed a wrong reason code. We know have a weak workaround that checks if the hiddenWindow is ready. It can easily fail if the hidden window is initialized faster.
Blocks: 857598
Attached file Pull request 922
Assignee: nobody → poirot.alex
Attachment #733446 - Flags: review?(rFobic)
Attachment #733446 - Flags: review?(rFobic) → review+
Note that this patch depends on bug 857602, that isn't landed.
I do not have much time to figure out if these two patches still applies and works.
That makes me sad to not drive this bug to the end and see this potential race still exists,
but given that in months I never had time to look at any sdk bug, I'm unassigning to all sdk-related bugs to keep a chance for someone to take them.
Assignee: poirot.alex → nobody
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: