Closed Bug 858108 Opened 9 years ago Closed 9 years ago

GC: Root the Locale interface

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(1 file)

Attached patch Proposed changesSplinter Review
Here's a patch to root the Locale interface.

I guess if you're ok with this I should also get this reviewed externally too?
Attachment #733382 - Flags: review?(terrence)
Comment on attachment 733382 [details] [diff] [review]
Proposed changes

Review of attachment 733382 [details] [diff] [review]:
-----------------------------------------------------------------

Very nice!

::: js/xpconnect/src/XPCLocale.cpp
@@ +225,2 @@
>                                 reinterpret_cast<jschar*>(unichars),
>                                 unicharLength);

Indent.
Attachment #733382 - Flags: review?(terrence) → review+
Comment on attachment 733382 [details] [diff] [review]
Proposed changes

Review of attachment 733382 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/src/XPCLocale.cpp
@@ +225,4 @@
>                                 reinterpret_cast<jschar*>(unichars),
>                                 unicharLength);
> +          if (str) {
> +            rval.set(STRING_TO_JSVAL(str));

setString
Attachment #733382 - Flags: review?(bobbyholley+bmo)
Comment on attachment 733382 [details] [diff] [review]
Proposed changes

Review of attachment 733382 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me on the XPCLocale changes
Attachment #733382 - Flags: review?(bobbyholley+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/59e4c48fa13f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Blocks: 773686
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.