858108 - GC: Root the Locale interface

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jon Coppeard (:jonco)]

Attachment: Proposed changes

Here's a patch to root the Locale interface.

I guess if you're ok with this I should also get this reviewed externally too?

Comment 1

[Terrence Cole [:terrence]]

Comment on attachment 733382 [details] [diff] [review]
Proposed changes

Review of attachment 733382 [details] [diff] [review]:
-----------------------------------------------------------------

Very nice!

::: js/xpconnect/src/XPCLocale.cpp
@@ +225,2 @@
>                                 reinterpret_cast<jschar*>(unichars),
>                                 unicharLength);

Indent.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 733382 [details] [diff] [review]
Proposed changes

Review of attachment 733382 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/src/XPCLocale.cpp
@@ +225,4 @@
>                                 reinterpret_cast<jschar*>(unichars),
>                                 unicharLength);
> +          if (str) {
> +            rval.set(STRING_TO_JSVAL(str));

setString

Comment 3

[Bobby Holley (:bholley)]

Comment on attachment 733382 [details] [diff] [review]
Proposed changes

Review of attachment 733382 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me on the XPCLocale changes

Comment 4

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/59e4c48fa13f

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/59e4c48fa13f