858171 - Miscellaneous code clean up

Status: RESOLVED FIXED

(Tree Management Graveyard :: OrangeFactor, defect)

Description

[Mark Côté [:mcote]]

There are a variety of little things to be cleaned up in both the Python and JS, including unused/undeclared/redeclared variables, bad code style, etc.  I'll do some without changing any logic for easier review.

Comment 1

[Mark Côté [:mcote]]

Attachment: Miscellaneous code cleanup

Sorry this patch is rather huge, but there was a lot of stuff that bothered me. :)

Most of the fixes are to indentation (especially the getJSON() callbacks, which were massively indented), spacing (horizontal and vertical), and variable declaration/initialization.  I also fixed some really long lines, but only where it was really easy; there are still lots of long lines in the JS that I didn't bother with.

This should make hacking on OF *slightly* more pleasing. :)

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 736899 [details] [diff] [review]
Miscellaneous code cleanup

Review of attachment 736899 [details] [diff] [review]:
-----------------------------------------------------------------

::: server/handlers.py
@@ +206,2 @@
>      def getPushLogData(self, args):
> +        """Retrieves the tbpl data from elasticsearch DB."""

I know this was the original comment wording, but wondering if we'd be better off with something like:
"Retrieves the tbpl comment submissions from elasticsearch DB."

Also, the function name is slightly misleading, but I'm sure it's not the only one in this file! :-)

Comment 3

[Mark Côté [:mcote]]

Okay, updated the comment (and a couple other little cleanups, including removing an out-of-date platform list in a comment).

Pushed and deployed.

http://hg.mozilla.org/automation/orangefactor/rev/8bb01b4aa231