Closed Bug 858242 Opened 12 years ago Closed 12 years ago

[FHR] Privacy Policy isn't linked from the sharing doorhanger and clicking it targets the graph toggle instead

Categories

(Firefox Health Report Graveyard :: Web: Health Report, defect, P1)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: lco, Assigned: espressive)

References

Details

Attachments

(1 file)

STR: 1. Make sure data sharing is OFF. 2. Turn data sharing ON from the toggle 3. Click on Privacy Policy link Expected: A new tab opens with the Privacy Policy page, FHR section. Actual: The link isn't active, and clicking on it will switch the graph view (from All to Average or vice versa) instead if the mouse is on top of that toggle. Note that the Privacy Policy link isn't active in either doorhanger (with data sharing ON or OFF)
Assignee: nobody → sneethling
In addition, I'd like a static link to the privacy policy placed as part of a footer for the FHR page. Both of these need to be fixed before FHR can move to GA.
(In reply to Alex Fowler from comment #1) > In addition, I'd like a static link to the privacy policy placed as part of > a footer for the FHR page. > > Both of these need to be fixed before FHR can move to GA. Alex, I (or Alina) will make a separate bug for this issue.
Component: General → about:healthreport
Product: Webtools → Firefox Health Report
Blocks ship in 21.
Severity: normal → blocker
Priority: -- → P1
Sent pull request: https://github.com/mozilla/fhr-jelly/pull/71 NOTE ----- Currently the policy links will open in the same window, the reason for this is because the target attribute has been deprecated so we cannot use this without failing validation unless we use a transitional doctype. The alternative is to use javascript to open these in a new tab but, the fallback, if javascript is disabled, will still be to open in the same window. With that said, if javascript is turned of FHR will basically be useless so it is basically a decision that needs to be made. Are we ok with it opening in the same window or not.
(In reply to Schalk Neethling [:espressive] from comment #4) > Sent pull request: https://github.com/mozilla/fhr-jelly/pull/71 > > NOTE > ----- > > Currently the policy links will open in the same window, the reason for this > is because the target attribute has been deprecated so we cannot use this > without failing validation unless we use a transitional doctype. > > The alternative is to use javascript to open these in a new tab but, the > fallback, if javascript is disabled, will still be to open in the same > window. With that said, if javascript is turned of FHR will basically be > useless so it is basically a decision that needs to be made. Are we ok with > it opening in the same window or not. The ideal design would be to open the privacy policy in a new window or tab so that the user can view it without leaving Health Report. But I'm ok with an edge case of opening the privacy policy in the same window if the user has disabled javascript. This being said, the patch for opening in a new window or tab isn't blocking for GA.
(In reply to Larissa Co [:lco] from comment #5) > (In reply to Schalk Neethling [:espressive] from comment #4) > > Sent pull request: https://github.com/mozilla/fhr-jelly/pull/71 > > > > NOTE > > ----- > > > > Currently the policy links will open in the same window, the reason for this > > is because the target attribute has been deprecated so we cannot use this > > without failing validation unless we use a transitional doctype. > > > > The alternative is to use javascript to open these in a new tab but, the > > fallback, if javascript is disabled, will still be to open in the same > > window. With that said, if javascript is turned of FHR will basically be > > useless so it is basically a decision that needs to be made. Are we ok with > > it opening in the same window or not. > > The ideal design would be to open the privacy policy in a new window or tab > so that the user can view it without leaving Health Report. But I'm ok with > an edge case of opening the privacy policy in the same window if the user > has disabled javascript. > > This being said, the patch for opening in a new window or tab isn't blocking > for GA. Ok, will handle the opening with JS with a fallback to opening in the same window.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
QA verified on dev - the privacy policy is accessible (follow STR in comment 0).
Status: RESOLVED → VERIFIED
Blocks: 867643
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: