858271 - logLevel property for deviceManager

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Mihnea Dobrescu-Balaur (:mihneadb)]

As mentioned in #793202.

Comment 1

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: expose the logLevel property; deprecate dm.debug; s/self.logger/self._logger

As I was talking to :callek, I'm not sure how we prefer to print the "deprecated" warning. With logger.warn it might not get printed. With a regular print, someone might redirect the logger to a file and just miss the printed warning.

Comment 2

[William Lachance (:wlach)]

Comment on attachment 733599 [details] [diff] [review]
expose the logLevel property; deprecate dm.debug; s/self.logger/self._logger

This looks good. I'm honestly not *too* worried about whether or not people see the deprecation warning.

Comment 3

[William Lachance (:wlach)]

(In reply to William Lachance (:wlach) from comment #2)
> Comment on attachment 733599 [details] [diff] [review]
> expose the logLevel property; deprecate dm.debug; s/self.logger/self._logger
> 
> This looks good. I'm honestly not *too* worried about whether or not people
> see the deprecation warning.

Specifically because it's not that much of a burden to keep these setters around indefinitely. I'm sure in a few years all our harness code will have been updated for the new setting.

Comment 4

[Mihnea Dobrescu-Balaur (:mihneadb)]

Ok, any need to ask for r? ?

Comment 5

[William Lachance (:wlach)]

Comment on attachment 733599 [details] [diff] [review]
expose the logLevel property; deprecate dm.debug; s/self.logger/self._logger

Going ahead and giving this an r+. There were no issues that I could see with the implementation, everything looks good to go.

Comment 6

[William Lachance (:wlach)]

Pushed: https://github.com/mozilla/mozbase/commit/ef75de65d632513854460ba7a935c872d8732fa4