858292 - gfx defects in shumway demos when skia-gl enabled

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect, P1)

Description

[Geoff Brown [:gbrown]]

Attachment: pacman demo on Galaxy S with default prefs (cairo)

The Shumway project has some demos available at http://mozilla.github.com/shumway/; they usually run fine on Android nightlies.

With skia-gl enabled:
  gfx.canvas.azure.accelerated=true
  gfx.canvas.azure.backends=skia
these demos often have graphics defects.

See attached screenshots of http://mozilla.github.com/shumway/examples/inspector/inspector.html?rfile=../pac/pac3.swf with/without skia-gl. These show the 13-04-04 nightly.

The defects seem slightly intermittent, but happen most (80%) of the time.

(I understand :blassey reported this issue on my behalf at a meeting today.)

Comment 1

[Geoff Brown [:gbrown]]

Attachment: pacman demo on Galaxy S with skia-gl enabled

Comment 2

[Geoff Brown [:gbrown]]

Attachment: pacman demo on Galaxy Tab with default prefs (cairo)

Comment 3

[Geoff Brown [:gbrown]]

Attachment: pacman demo on Galaxy Tab with skia-gl enabled

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Preserve drawing buffer when using SkiaGL

Comment 5

[George Wright (:gw280) (needinfo me!)]

Comment on attachment 736844 [details] [diff] [review]
Preserve drawing buffer when using SkiaGL

As we discussed on IRC, this seems to cause Fennec to crash after a short while, and hammers our performance. I think we need to look further for a solution.

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to George Wright (:gw280) from comment #5)
> Comment on attachment 736844 [details] [diff] [review]
> Preserve drawing buffer when using SkiaGL
> 
> As we discussed on IRC, this seems to cause Fennec to crash after a short
> while, and hammers our performance. I think we need to look further for a
> solution.

Yeah, I'm looking into the crash right now. We may be able to do something about the performance, but at least in some circumstances it's definitely going to be worse than what we have now because of the copy.

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 736844 [details] [diff] [review]
Preserve drawing buffer when using SkiaGL

Now that bug 862448 landed, this patch works fine.

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/16f3bfd127f9

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/16f3bfd127f9