Closed Bug 858292 Opened 7 years ago Closed 7 years ago

gfx defects in shumway demos when skia-gl enabled

Categories

(Firefox for Android :: Toolbar, defect, P1)

x86
Android
defect

Tracking

()

RESOLVED FIXED
Firefox 23

People

(Reporter: gbrown, Assigned: snorp)

References

Details

(Whiteboard: [shumway])

Attachments

(5 files)

The Shumway project has some demos available at http://mozilla.github.com/shumway/; they usually run fine on Android nightlies.

With skia-gl enabled:
  gfx.canvas.azure.accelerated=true
  gfx.canvas.azure.backends=skia
these demos often have graphics defects.

See attached screenshots of http://mozilla.github.com/shumway/examples/inspector/inspector.html?rfile=../pac/pac3.swf with/without skia-gl. These show the 13-04-04 nightly.

The defects seem slightly intermittent, but happen most (80%) of the time.

(I understand :blassey reported this issue on my behalf at a meeting today.)
Assignee: nobody → snorp
Attachment #736844 - Flags: review?(gwright)
Comment on attachment 736844 [details] [diff] [review]
Preserve drawing buffer when using SkiaGL

As we discussed on IRC, this seems to cause Fennec to crash after a short while, and hammers our performance. I think we need to look further for a solution.
Attachment #736844 - Flags: review?(gwright) → review-
(In reply to George Wright (:gw280) from comment #5)
> Comment on attachment 736844 [details] [diff] [review]
> Preserve drawing buffer when using SkiaGL
> 
> As we discussed on IRC, this seems to cause Fennec to crash after a short
> while, and hammers our performance. I think we need to look further for a
> solution.

Yeah, I'm looking into the crash right now. We may be able to do something about the performance, but at least in some circumstances it's definitely going to be worse than what we have now because of the copy.
Whiteboard: [shumway]
Priority: -- → P1
Comment on attachment 736844 [details] [diff] [review]
Preserve drawing buffer when using SkiaGL

Now that bug 862448 landed, this patch works fine.
Attachment #736844 - Flags: review- → review?(gwright)
Attachment #736844 - Flags: review?(gwright) → review+
https://hg.mozilla.org/mozilla-central/rev/16f3bfd127f9
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
You need to log in before you can comment on or make changes to this bug.