858305 - Need change to abouthealth.css to work around lack of flexbox support

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Laura Thomson :laura]

(As discussed in IRC, getting a bug on file.)

Turns out that as well as the server-side piece depending on flexbox (bug 858264), the chrome also depends on flexbox.  Since this did not ship in 21.0 beta, we need to work around it.

Schalk has a solution.  The contents of abouthealth.css should change to:
--
* {
  margin: 0;
  padding: 0;
}

html, body {
  background-color: rgb(250, 250, 250);
  height: 99%;
}

#remote-report {
  width: 100%;
  height: 100%;
  border: 0;
} 
--

Until this lands (hopefully in the next beta), about:healthreport will have a double scrollbar.

mconnor, can you test and land it please?

Comment 1

[Mike Connor [:mconnor]]

Attachment: workaround for flexbox being disabled

tested on a local beta build, eliminates the double scrollbar.

Comment 2

[u279076]

Under what circumstances does the double scrollbar appear? I have yet to reproduce this bug.

Comment 3

[Laura Thomson :laura]

ashughes: If the content needs a scrollbar - try looking at the Raw Data tab.

Comment 4

[u279076]

(In reply to Laura Thomson :laura from comment #3)
> ashughes: If the content needs a scrollbar - try looking at the Raw Data tab.

Thanks Laura, I can see this bug now.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 733933 [details] [diff] [review]
workaround for flexbox being disabled

rs=me, but I really wish we'd revisit this styling with someone who knows how to actually make this work right.

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 733933 [details] [diff] [review]
workaround for flexbox being disabled

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 841873 happened and MDN was in a confusing state way back when.
User impact if declined: Double scrollbar on about:healthreport
Testing completed (on m-c, etc.): locally verified on beta. will have QA verify after landing.
Risk to taking this patch (and alternatives if risky): minimal to none, no risk outside of about:healthreport
String or IDL/UUID changes made by this patch: none

Comment 7

[bhavana bajaj [:bajaj]]

Comment on attachment 733933 [details] [diff] [review]
workaround for flexbox being disabled

Approving on beta, helps avoid the double scrollbar issue for FHR reports in about:healthreport.

Comment 8

[bhavana bajaj [:bajaj]]

(In reply to Mike Connor [:mconnor] from comment #6)
> Comment on attachment 733933 [details] [diff] [review]
> workaround for flexbox being disabled
> 
> [Approval Request Comment]
> Bug caused by (feature/regressing bug #): 841873 happened and MDN was in a
> confusing state way back when.
> User impact if declined: Double scrollbar on about:healthreport
> Testing completed (on m-c, etc.): locally verified on beta. will have QA
> verify after landing.
> Risk to taking this patch (and alternatives if risky): minimal to none, no
> risk outside of about:healthreport
> String or IDL/UUID changes made by this patch: none

mconnor, Bug 841876 - Re-enable flexbox pref (by default) in release builds  should be enabled on aurora. Is this the bug we need to avoid the Flexbox issue ?

If its enabled per Bug 841876 on Fx22, would this patch still be needed there ?

Comment 9

[bhavana bajaj [:bajaj]]

(In reply to Mike Connor [:mconnor] from comment #6)
> Comment on attachment 733933 [details] [diff] [review]
> workaround for flexbox being disabled
> 
> [Approval Request Comment]
> Bug caused by (feature/regressing bug #): 841873 happened and MDN was in a
> confusing state way back when.
> User impact if declined: Double scrollbar on about:healthreport
> Testing completed (on m-c, etc.): locally verified on beta. will have QA
> verify after landing.
> Risk to taking this patch (and alternatives if risky): minimal to none, no
> risk outside of about:healthreport
> String or IDL/UUID changes made by this patch: none

Please make sure to land before/by Monday morning as we are targeting go-to-build early PT Monday morning.Thanks !

Comment 10

[Mike Connor [:mconnor]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2c2a5fce2c7b

Can't set the correct flags, but this is fixed on beta, I'll land on trunk tomorrow.

Comment 11

[Mike Connor [:mconnor]]

Assuming bug 841876 sticks, we're done here.

Comment 12

[Ada [:adalucinet]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20100101 Firefox/21.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20100101 Firefox/21.0
Mozilla/5.0 (X11; Linux i686; rv:21.0) Gecko/20100101 Firefox/21.0

Reproduced this issue with Firefox 21 beta 1 (Build ID: 20130401192816) based on comment 3.

Verified as fixed on Firefox 21 beta 2 (Build ID: 20130408165307). No double scrollbar in about:healthreport.

Comment 13

[Alex Keybl [:akeybl]]

actually, setting the approval back to a nomination for Aurora (not clear if this is the permanent solution). ni on mconnor for comment 8.

Comment 14

[bhavana bajaj [:bajaj]]

Comment on attachment 733933 [details] [diff] [review]
workaround for flexbox being disabled

As Flexbox will be enabled in Fx22 this patch is no longer needed on aurora.

Comment 15

[Mike Connor [:mconnor]]

Yes, as long as flexbox stays enabled, this needs no further action.