858323 - Selection is black if content isn't focused when selection starts

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[:Margaret Leibovic]

When we were using a fake mouse event to start selection, a side effect was that it would focus the content where the selection is happening. Because that's no longer the case, we should do something to make sure the content window is focused when starting a selection.

Comment 1

[:Margaret Leibovic]

Attachment: Focus tab.browser when the tab is selected

I found the issue here is that the browser element wasn't focused. Instead of trying to focus it whenever text selection starts, I decided to focus it when we set the selected tab.

Comment 2

[Wesley Johnston (:wesj)]

Comment on attachment 738190 [details] [diff] [review]
Focus tab.browser when the tab is selected

Review of attachment 738190 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe add a comment explaining why we need this.

Comment 3

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb1cb21e711c

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bb1cb21e711c

Comment 5

[:Margaret Leibovic]

Comment on attachment 738190 [details] [diff] [review]
Focus tab.browser when the tab is selected

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 854605
User impact if declined: text selection will be black unless the user taps on the content to focus it first
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): low-risk, focuses browser when selected instead of when a user taps on the content
String or IDL/UUID changes made by this patch: n/a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/12e463ae355c