Closed Bug 858377 Opened 7 years ago Closed 7 years ago

Intermittent test_393498.js | false == true

Categories

(Toolkit :: Places, defect)

x86
Windows 8
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24
Tracking Status
firefox23 --- fixed
firefox24 --- fixed

People

(Reporter: philor, Assigned: mak)

References

Details

(Keywords: intermittent-failure)

+++ This bug was initially created as a clone of Bug #606638 +++

https://tbpl.mozilla.org/php/getParsedLog.php?id=21452007&tree=Mozilla-Inbound
WINNT 6.2 mozilla-inbound opt test xpcshell on 2013-04-04 10:06:25 PDT for push 24d4bd4b5fd7
slave: t-w864-ix-051

17:15:22  WARNING -  TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\xpcshell\tests\toolkit\components\places\tests\bookmarks\test_393498.js | test failed (with xpcshell return code: 0), see following log:
17:15:22     INFO -  >>>>>>>
17:15:22     INFO -  TEST-INFO | (xpcshell/head.js) | test 1 pending
17:15:22     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_393498.js | [run_test : 50] true == true
17:15:22     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_393498.js | [run_test : 57] dateAdded == dateAdded
17:15:22     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_393498.js | [run_test : 58] 1365120922305000 == 1365120922305000
17:15:22     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_393498.js | [run_test : 61] 1365120922305000 == 1365120922305000
17:15:22     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_393498.js | [run_test : 65] 1365120922305000 == 1365120922305000
17:15:22     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_393498.js | [run_test : 69] lastModified == lastModified
17:15:22     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_393498.js | [run_test : 70] 1365120922305000 == 1365120922305000
17:15:22     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_393498.js | [run_test : 72] 1365120922305000 == 1365120922305000
17:15:22     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_393498.js | [run_test : 76] 7 == 7
17:15:22     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_393498.js | [run_test : 77] title == title
17:15:22     INFO -  TEST-PASS | C:/slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_393498.js | [run_test : 78] Google == Google
17:15:22  WARNING -  TEST-UNEXPECTED-FAIL | C:/slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_393498.js | false == true - See following stack:
17:15:22     INFO -  JS frame :: C:\slave\test\build\tests\xpcshell\head.js :: do_throw :: line 461
17:15:22     INFO -  JS frame :: C:\slave\test\build\tests\xpcshell\head.js :: do_report_result :: line 563
17:15:22     INFO -  JS frame :: C:\slave\test\build\tests\xpcshell\head.js :: _do_check_eq :: line 573
17:15:22     INFO -  JS frame :: C:\slave\test\build\tests\xpcshell\head.js :: do_check_eq :: line 580
17:15:22     INFO -  JS frame :: C:\slave\test\build\tests\xpcshell\head.js :: do_check_true :: line 594
17:15:22     INFO -  JS frame :: C:/slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/bookmarks/test_393498.js :: run_test :: line 81
17:15:22     INFO -  JS frame :: C:\slave\test\build\tests\xpcshell\head.js :: _execute_test :: line 325
17:15:22     INFO -  JS frame :: -e :: <TOP_LEVEL> :: line 1
17:15:22     INFO -  native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
17:15:22     INFO -  TEST-INFO | (xpcshell/head.js) | exiting test
17:15:22     INFO -  <<<<<<<
Marco, don't suppose you could take a look at this? It is one of our more frequent oranges at the moment. Seems to be WinXP-only.
Flags: needinfo?(mak77)
(In reply to Ed Morley [:edmorley UTC+1] from comment #117)
> Marco, don't suppose you could take a look at this? It is one of our more
> frequent oranges at the moment. Seems to be WinXP-only.

#1 orange now.
Whiteboard: [disable-me 2013-06-05]
looks like the skew between PR_Now and Date.now() changed recently, so while this test was mostly working with the old implementation that considered a 10ms skew, now it fails more often... since it's not important for the test itself I'll just bump the past time to 24 hours ago, and clean up the test a bit, since it's oldish.
Flags: needinfo?(mak77)
Assignee: nobody → mak77
Status: NEW → ASSIGNED
most of the changes are just cleanup, the only real change to the test is the increase of time skew between the past date and now()

https://hg.mozilla.org/integration/mozilla-inbound/rev/b2bf68201b50
Whiteboard: [disable-me 2013-06-05]
https://hg.mozilla.org/mozilla-central/rev/b2bf68201b50
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla24