Closed Bug 858486 Opened 7 years ago Closed 7 years ago

Make SecureMail not die if insidergroup is undefined

Categories

(bugzilla.mozilla.org :: Extensions, defect)

Production
defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: gerv, Assigned: gerv)

Details

Attachments

(1 file)

[Filing here because upstream doesn't have a component.]

If insidergroup is not defined, SecureMail fails with an error. We need to test for the existence of insidergroup, as well as its contents, on line 276 of SecureMail's Extension.pm. (Line number from BMO version.)

Gerv
Thanks for the report Gerv. If you have cycles to take a look at this issue then feel free. Otherwise we can take a look at it soon when we finish up some other Q1 projects we are working on.

Thanks
dkl
Severity: normal → minor
Attached patch Patch v.1Splinter Review
Assignee: nobody → gerv
Status: NEW → ASSIGNED
Attachment #753327 - Flags: review?(dkl)
Comment on attachment 753327 [details] [diff] [review]
Patch v.1

Review of attachment 753327 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #753327 - Flags: review?(dkl) → review+
Committing  to: bzr+ssh://bzr.mozilla.org/bmo/4.2/                            
modified extensions/SecureMail/Extension.pm
Committed revision 8832.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Component: Extensions: SecureMail → Extensions
You need to log in before you can comment on or make changes to this bug.