Closed
Bug 858561
Opened 11 years ago
Closed 11 years ago
Move BrowserDB.expireHistory from GeckoApp.onPause to GeckoApplication.onActivityPause
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox20+ fixed, firefox21+ fixed, firefox22+ fixed, firefox23 fixed)
RESOLVED
FIXED
Firefox 23
People
(Reporter: mfinkle, Assigned: mfinkle)
Details
Attachments
(1 file)
3.83 KB,
patch
|
kats
:
review+
bajaj
:
approval-mozilla-aurora+
bajaj
:
approval-mozilla-beta+
lsblakk
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
GeckoApp.onPause is called when opening Settings and Awesomescreen activities. We only want to expire history when pausing the entire app. The way it works now can cause DB activity when open the awesomebar, potentially slowing it all down. This patch builds and runs fine.
Attachment #733851 -
Flags: review?(bugmail.mozilla)
Comment 1•11 years ago
|
||
Comment on attachment 733851 [details] [diff] [review] patch Review of attachment 733851 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #733851 -
Flags: review?(bugmail.mozilla) → review+
Assignee | ||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ccb2618918a8
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ccb2618918a8
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 733851 [details] [diff] [review] patch [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Shown to cause DB locks in crash stats. This reduces the likelihood of a DB lock and reduces DB work happening when opring the awesomescreen. Testing completed (on m-c, etc.): on m-c Risk to taking this patch (and alternatives if risky): low risk String or IDL/UUID changes made by this patch: none
Attachment #733851 -
Flags: approval-mozilla-beta?
Attachment #733851 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
Assignee: nobody → mark.finkle
status-firefox21:
--- → affected
status-firefox22:
--- → affected
tracking-firefox21:
--- → +
tracking-firefox22:
--- → +
Comment 5•11 years ago
|
||
Comment on attachment 733851 [details] [diff] [review] patch low risk, stability win with DB related crashes we have been seeing for a while now.
Attachment #733851 -
Flags: approval-mozilla-beta?
Attachment #733851 -
Flags: approval-mozilla-beta+
Attachment #733851 -
Flags: approval-mozilla-aurora?
Attachment #733851 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/d21e1173198c https://hg.mozilla.org/releases/mozilla-beta/rev/3c4a6e5913eb
Comment 7•11 years ago
|
||
Comment on attachment 733851 [details] [diff] [review] patch [Triage Comment] We're going to take this for a 20.0.1 mobile respin.
Attachment #733851 -
Flags: approval-mozilla-release+
Updated•11 years ago
|
status-firefox20:
--- → affected
tracking-firefox20:
--- → +
Assignee | ||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-release/rev/39a5c953cba5
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•