858561 - Move BrowserDB.expireHistory from GeckoApp.onPause to GeckoApplication.onActivityPause

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

GeckoApp.onPause is called when opening Settings and Awesomescreen activities. We only want to expire history when pausing the entire app. The way it works now can cause DB activity when open the awesomebar, potentially slowing it all down.

This patch builds and runs fine.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 733851 [details] [diff] [review]
patch

Review of attachment 733851 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ccb2618918a8

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ccb2618918a8

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 733851 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Shown to cause DB locks in crash stats. This reduces the likelihood of a DB lock and reduces DB work happening when opring the awesomescreen.
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low risk
String or IDL/UUID changes made by this patch: none

Comment 5

[bhavana bajaj [:bajaj]]

Comment on attachment 733851 [details] [diff] [review]
patch

low risk, stability win with DB related crashes we have been seeing for a while now.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d21e1173198c
https://hg.mozilla.org/releases/mozilla-beta/rev/3c4a6e5913eb

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 733851 [details] [diff] [review]
patch

[Triage Comment]
We're going to take this for a 20.0.1 mobile respin.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-release/rev/39a5c953cba5