858649 - Add support for raw github pull request diffs/patches

Status: NEW

(Bugzilla :: Attachments & Requests, enhancement)

Description

[David Humphrey (:humph)]

A github pull request can be transformed into a full diff/patch by adding either .diff or .patch to the pull request URL.  For example:

https://github.com/mozilla/butter/pull/1643
https://github.com/mozilla/butter/pull/1643.diff
https://github.com/mozilla/butter/pull/1643.patch

It seems that the recommended way to do review for github pull requests in bugzilla is to paste the pull request link as your attachment.  It would be nice if, as a reviewer, I could work with the actual patch in bugzilla without having to go to github.  Perhaps adding a button to the attachment edit page that allows me to copy the raw pull request patch into the comment textarea, which would mean I could do a review the same as if I was working with an uploaded patch.

See also bug 752871.

Comment 1

[Frédéric Buclin]

Isn't that a duplicate of bug 791095?

Comment 2

[David Humphrey (:humph)]

No, the URLs work now.  What I'm asking for is something different, namely, that a particular type of URL (github pull request) would trigger a further action, either automatically downloading the patch and putting it in the comment area, or having a button to do this, etc.