858654 - Add Thumbnail Input to Project Editor

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Comment 1

[Chris DeCairos (:cade)]

Missed the description - We need a tool to drag/drop or specify a link to an image that will be used as a thumbnail or potentially a poster frame for a project.

Comment 2

[Brett Gaylor [:brett]]

maybe im missing this but why not use the same functionality from the image editor?

Comment 3

[Matthew Schranz [:mjschranz]]

That's exactly what it was. The code exists for this all to just drop in place. Truthfully Chris should be able to just open a PR with it pretty quick considering the fact the main UI changes to the editor have landed.

Comment 4

[Chris DeCairos (:cade)]

Attachment: Front-end changes for thumbnail input.

https://github.com/mozilla/butter/pull/1658

still needs work, but I would like some feedback.

Comment 5

[Jon Buckley]

Comment on attachment 735150 [details] [review]
Front-end changes for thumbnail input.

Front-end is fine, but the backend hasn't been changed out yet, so lets just wait on this.

Comment 6

[Brett Gaylor [:brett]]

Does this feature a default thumbnail?  I'd like it to - the popcorn maker logo is fine for now.

Comment 7

[Chris DeCairos (:cade)]

:brett - It doesn't have one in it's current state, I'll modify the changes so that every new project gets the popcorn logo as a default thumbnail (for now)

Comment 8

[Chris DeCairos (:cade)]

Opened a new pull, github got confused after I rebased.

https://github.com/mozilla/butter/pull/1672

Comment 9

[Matthew Schranz [:mjschranz]]

Chris, I just reviewed over the code again. I want to move along and get this and bug 858739 landed. Can you land this? I can take over for the backend changes, but I'm guessing you still have the original code for them sitting somewhere.

Comment 10

[Chris DeCairos (:cade)]

Staged on Master: https://github.com/mozilla/butter/commit/9b0d773c325553e8a54690fda402afd954615757