do_GetAtom is fallible, but consumers assume it's not

RESOLVED FIXED in mozilla23

Status

()

Core
XPCOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

unspecified
mozilla23
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

As far as I can tell, many consumers of do_GetAtom assume it's infallible, whereas in practice it can return null.

Should we just make this infallible?
(In reply to Boris Zbarsky (:bz) from comment #0)
> Should we just make this infallible?

Yes.
Created attachment 733990 [details] [diff] [review]
Make do_GetAtom infallible.
Attachment #733990 - Flags: review?(khuey)
Assignee: nobody → bzbarsky
Whiteboard: [need review]
https://hg.mozilla.org/integration/mozilla-inbound/rev/d37a93af33a8
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla23

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/d37a93af33a8
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.