Closed
Bug 858689
Opened 11 years ago
Closed 11 years ago
sending an SMS fails on Android
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: blassey, Assigned: blassey)
Details
Attachments
(2 files, 1 obsolete file)
2.66 KB,
patch
|
mounir
:
review+
|
Details | Diff | Splinter Review |
2.70 KB,
patch
|
Details | Diff | Splinter Review |
QueueSmsRequest() fails in SendMessage() because sSmsRequests is null.
Attachment #733967 -
Flags: review?(mounir)
Comment 1•11 years ago
|
||
Comment on attachment 733967 [details] [diff] [review] patch Review of attachment 733967 [details] [diff] [review]: ----------------------------------------------------------------- You should explicitly set the static variable to null or call |ClearOnShutdown(&sSmsRequests);|. As far as I know, this is leaking.
Attachment #733967 -
Flags: review?(mounir) → review-
Assignee | ||
Comment 2•11 years ago
|
||
upon further review, I see no reason for this to be static
Assignee: nobody → blassey.bugs
Attachment #733967 -
Attachment is obsolete: true
Attachment #734629 -
Flags: review?(mounir)
Updated•11 years ago
|
Attachment #734629 -
Flags: review?(mounir) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 3•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Attachment #736469 -
Attachment is patch: true
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8165938b2dd4
Keywords: checkin-needed
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8165938b2dd4
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•