Closed Bug 858689 Opened 7 years ago Closed 7 years ago

sending an SMS fails on Android

Categories

(Core :: DOM: Device Interfaces, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: blassey, Assigned: blassey)

Details

Attachments

(2 files, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
QueueSmsRequest() fails in SendMessage() because sSmsRequests is null.
Attachment #733967 - Flags: review?(mounir)
Comment on attachment 733967 [details] [diff] [review]
patch

Review of attachment 733967 [details] [diff] [review]:
-----------------------------------------------------------------

You should explicitly set the static variable to null or call |ClearOnShutdown(&sSmsRequests);|. As far as I know, this is leaking.
Attachment #733967 - Flags: review?(mounir) → review-
Attached patch patchSplinter Review
upon further review, I see no reason for this to be static
Assignee: nobody → blassey.bugs
Attachment #733967 - Attachment is obsolete: true
Attachment #734629 - Flags: review?(mounir)
Attachment #734629 - Flags: review?(mounir) → review+
Attachment #736469 - Attachment is patch: true
https://hg.mozilla.org/mozilla-central/rev/8165938b2dd4
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.