858700 - Swap out better binding helper names for xbtoc, ybtoc, xctob, yctob

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Input, defect)

Comment 1

[Jim Mathies [:jimm]]

str:

1) tap in a text edit that is near the bottom of the page
2) once the view adjusts, select some text
3) press hold

the context menu will be down below the keyboard.

Comment 2

[Jim Mathies [:jimm]]

Attachment: fix

easy peasy review.

The more I stare at these helpers, the more I think I should have named them btocx/btocy vs. the other way around. :/

Comment 3

[Matt Brubeck (:mbrubeck)]

Comment on attachment 733989 [details] [diff] [review]
fix

Review of attachment 733989 [details] [diff] [review]:
-----------------------------------------------------------------

Also r+ if you want to search-and-replace to flip the helper function identifiers.  (I also prefer the names ending in "cx" and "cy".)

Comment 4

[Jim Mathies [:jimm]]

I already got this in the bindings patch, it's over on inbound and I got my local repo out of sync. sorry for wasting your time on that. lets morph this over to changing the binding names.

Comment 5

[Jim Mathies [:jimm]]

Attachment: patch

Comment 6

[Jim Mathies [:jimm]]

Attachment: patch

Comment 7

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b05237492a4c

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b05237492a4c