85880 - Clearing of <function-name>.arguments after function calls in interpreter mode

Status: VERIFIED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Igor Bukanov]

When run in interpreter mode (java org.mozilla.javascript.tools.shell.Main -opt
-1), the following prints "null" instead of expected "[object Arguments]":

function g(x) {
}

function f() {
	g();
	return f.arguments;
}

print(f(0))

I beliave this is caused by the following code in omj/ScriptRuntime.java, lines
1725-1727:

stack[stackTop] = ScriptRuntime.call(cx, lhs, rhs, 
                                     outArgs, 
                                     calleeScope);
if (theData.itsNeedsActivation) {
    ScriptRuntime.popActivation(cx);
}

which removes activation object after each function call.

Comment 1

[Igor Bukanov]

Attachment: Move ScriptRuntime.popActivation(cx) to omj.InterpretedFunction plus NativeCall cleanup

Comment 2

[Igor Bukanov]

Attachment: Move ScriptRuntime.popActivation(cx) to omj.InterpretedFunction plus NativeCall cleanup

Comment 3

[Igor Bukanov]

The attached patch moves ScriptRuntime.popActivation(cx) to the call method of
omj.InterpretedFunction in the similar way omj.optimizer.CdeGen does and removes
unused outside NativeCall NativeCall(Context, Scriptable, NativeFunction,
Scriptable) constructor by inlining its code.

Comment 4

[Norris Boyd]

Committed patch, marking fixed. Thanks, Igor.

Comment 5

[Phil Schwartau]

Testcase addded to JS test suite:

          js/tests/ecma_3/Function/regress-85880.js


Before fix, failing in Rhino interpreted mode only.
Passing in Rhino complied mode; passing in SpiderMonkey.

Comment 6

[Phil Schwartau]

After fix, testcase passing in both Rhino modes on WinNT.
Marking VERIFIED FIXED -